Disabled default returnedObjectHandler #1288
Conversation
…ich points to object when returnObjects is false
|
will be published in an upcoming version |
|
published in i18next@17.0.7 |
| @@ -32,7 +32,7 @@ export function get() { | |||
| returnEmptyString: true, // allows empty string value as valid translation | |||
| returnObjects: false, | |||
| joinArrays: false, // or string to join array | |||
| returnedObjectHandler: () => {}, // function(key, value, options) triggered if key returns object but returnObjects is set to false | |||
| returnedObjectHandler: false, // function(key, value, options) triggered if key returns object but returnObjects is set to false | |||
There was a problem hiding this comment.
@jamuhl If I get it right, somebody could expect a function here, couldn't they? If it's the case, does it break the top-level API? 🤔
There was a problem hiding this comment.
what are you talking about...
https://github.com/i18next/i18next/blob/master/src/Translator.js#L122
it just fixed the usage -> there should be a string returned to show something is wrong
before having a noop function it just did nothing...
There was a problem hiding this comment.
Yeah, I see that it's kind of default options and not used from the outside of the lib. Btw, it was just a question, not a passive-aggressive one 😄
There was a problem hiding this comment.
Gosh, now I'm super interested in what's actually been broken since a few recent versions 😃
There was a problem hiding this comment.
fun fact is v1 -> v17 is more or less the same exposed API
we still run v1.x.x tests with a compatibility mode (which was part of i18next until around v10): https://github.com/i18next/i18next/tree/master/test/backward
There was a problem hiding this comment.
Not taking it as aggressive - no worry - just as I try my best to not add to the "javascript-fatigue" by keeping the API as stable as possible by not breaking things. I got a little sad by the tweet.
There was a problem hiding this comment.
I got a little sad by the tweet.
Yeah, I'm sorry about that 😞
I think it'd be cool to see your answer to the initial tweet (what's actually broken and what's not) 👍
To allow returning of a key when
returnObjectsisfalse. See #1234More discussion in #1239