Only chown network files within container metadata #34224
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
estesp
force-pushed
the
no-chown-nwfiles-outside-metadata
branch
from
c02b1fe to
308f501
Compare
|
Thanks @thaJeztah; test added! |
If the user specifies a mountpath from the host, we should not be attempting to chown files outside the daemon's metadata directory (represented by `daemon.repository` at init time). This forces users who want to use user namespaces to handle the ownership needs of any external files mounted as network files (/etc/resolv.conf, /etc/hosts, /etc/hostname) separately from the daemon. In all other volume/bind mount situations we have taken this same line--we don't chown host file content. Docker-DCO-1.1-Signed-off-by: Phil Estes <estesp@linux.vnet.ibm.com>
estesp
force-pushed
the
no-chown-nwfiles-outside-metadata
branch
from
308f501 to
42716dc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the user specifies a mountpath from the host, we should not be
attempting to
chownfiles outside the daemon's metadata directory(represented by
daemon.repositoryat init time).This forces users who want to use user namespaces to handle the
ownership needs of any external files mounted as network files
(
/etc/resolv.conf,/etc/hosts,/etc/hostname) separately from thedaemon. In all other volume/bind mount situations we have taken this
same line--we don't
chownhost filesystem content.Docker-DCO-1.1-Signed-off-by: Phil Estes estesp@linux.vnet.ibm.com
@thaJeztah my only concern here is change in behavior if anyone has relied on mounting network files from a host system location and gotten this automatic "chown" behavior. Something we have to consider I guess.