Skip to content

LCOW: VHDX boot to readonly. #34754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 12, 2017
Merged

LCOW: VHDX boot to readonly. #34754

merged 2 commits into from
Sep 12, 2017

Conversation

lowenna
Copy link
Member

@lowenna lowenna commented Sep 6, 2017

Signed-off-by: John Howard jhoward@microsoft.com

Fixes internal VSO bug 12969254. Makes the VHDX boot read-only to avoid file sharing violation running 2nd container. @beweedon, @jstarks @PatrickLang FYI.

@johnstep PTAL.

John Howard added 2 commits September 6, 2017 10:55
Signed-off-by: John Howard <jhoward@microsoft.com>
Signed-off-by: John Howard <jhoward@microsoft.com>
Copy link
Member

@johnstep johnstep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@yongtang yongtang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the PR makes sense. LGTM if Jenkins passes.

@lowenna
Copy link
Member Author

lowenna commented Sep 12, 2017

Jenkins & GH are out-of-sync. RS1 completed successfully here: https://jenkins.dockerproject.org/job/Docker-PRs-WoW-RS1/16941/console

OK to merge? (Although restarted in the hope it will re-sync successfully)

@yongtang
Copy link
Member

All test passes now. Thanks! 👍

@yongtang yongtang merged commit 969b76d into moby:master Sep 12, 2017
@lowenna lowenna deleted the jjh/read-only branch September 13, 2017 01:06
@thaJeztah thaJeztah added the area/lcow Issues and PR's related to the experimental LCOW feature label Oct 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/lcow Issues and PR's related to the experimental LCOW feature status/4-merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants