-
Notifications
You must be signed in to change notification settings - Fork 18.7k
LCOW: VHDX boot to readonly. #34754
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LCOW: VHDX boot to readonly. #34754
Conversation
Signed-off-by: John Howard <jhoward@microsoft.com>
Signed-off-by: John Howard <jhoward@microsoft.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the PR makes sense. LGTM if Jenkins passes.
Jenkins & GH are out-of-sync. RS1 completed successfully here: https://jenkins.dockerproject.org/job/Docker-PRs-WoW-RS1/16941/console OK to merge? (Although restarted in the hope it will re-sync successfully) |
All test passes now. Thanks! 👍 |
Signed-off-by: John Howard jhoward@microsoft.com
Fixes internal VSO bug 12969254. Makes the VHDX boot read-only to avoid file sharing violation running 2nd container. @beweedon, @jstarks @PatrickLang FYI.
@johnstep PTAL.