"docker swarm init --force-new-cluster" use limit #34881
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daemon/cluster/swarm.go
Outdated
|
|
||
| if !c.nr.nodeState.IsManager() { | ||
| return "", errors.New("This node is not a swarm manager. Worker nodes can't be used to modify cluster state. Please run this command on a manager node or promote the current node to a manager.") | ||
| } |
There was a problem hiding this comment.
I think this should be moved down into the section below where c.mu is locked, since I believe that mutex needs to be locked to access nodeState.
Also, lint is complaining about the error message, so you may need to work around that by moving the message into a string constant. Is there not already a suitable message we can reuse?
There was a problem hiding this comment.
ok, I will modify it as soon as possible.
Signed-off-by: yangchenliang <yangchenliang@huawei.com> When worker executor `docker swarm init --force-new-cluster`,docker would hang.So only manager can process it. Signed-off-by: yangchenliang <yangchenliang@huawei.com>
ityangchen
force-pushed
the
test-moby
branch
from
cf9e920 to
12e947e
Compare
|
@aaronlehmann looks like the PR was updated |
aaronlehmann
approved these changes
Sep 27, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: yangchenliang yangchenliang@huawei.com
When worker executes
docker swarm init --force-new-cluster,docker would hang.So only manager can process it.- What I did
- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)