Skip to content

Stop filtering Windows manifest lists by version #35117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 10, 2017

Conversation

johnstep
Copy link
Member

@johnstep johnstep commented Oct 7, 2017

Signed-off-by: John Stephens johnstep@docker.com

Stop excluding incompatible Windows versions because it is possible to run some with Hyper-V isolation. However, still move compatible versions to the top, since they are preferred, but preserve the order if no compatible versions are found. More work is required to finalize the policy; for example, versions greater than the host should probably be excluded, even if just the UBR (Update Build Release) is higher.

Signed-off-by: John Stephens <johnstep@docker.com>
Copy link
Member

@lowenna lowenna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from code inspection. I’ll try to find time to verify this evening or tomorrow.

@StefanScherer StefanScherer mentioned this pull request Oct 9, 2017
1 task
Copy link
Member

@dmcgowan dmcgowan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants