Add a debug message when client closes websocket attach connection #35720
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the client closes websocket connections that sends container output through websocket, an error message is displayed: "Error attaching websocket: %!s(<nil>)" This message is misleading. Thus, this change suggests to check if error is nil and print the correct message accordingly. Signed-off-by: Boaz Shuster <ripcurld.github@gmail.com>
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
When the client closes connections that send containers output through websocket, an error message is displayed:
Error attaching websocket: %!s(<nil>)This message is misleading.
- How I did it
This change suggests to check if
errorisniland print the correct message accordingly.If
erroris notnil, printError attaching websocket:. Otherwise,websocket connection was closed by client.- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)