-
Notifications
You must be signed in to change notification settings - Fork 18.7k
devmapper.Mounted: remove #36437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
devmapper.Mounted: remove #36437
Conversation
It looks like no one uses this function. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SGTM :angel:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
) | ||
|
||
// FIXME: this is copy-pasted from the aufs driver. | ||
// It should be moved into the core. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, this was added a loooong time ago (4a8a7d4), and was to satisfy an interface that later changed (b8b509e / shykes#7). Looks like in aufs this is now moved to graphdriver.Mounted()
(in 65d79e3):
moby/daemon/graphdriver/aufs/aufs.go
Lines 581 to 583 in 3a633a7
func (a *Driver) mounted(mountpoint string) (bool, error) { | |
return graphdriver.Mounted(graphdriver.FsMagicAufs, mountpoint) | |
} |
Codecov Report
@@ Coverage Diff @@
## master #36437 +/- ##
=========================================
Coverage ? 34.91%
=========================================
Files ? 613
Lines ? 45365
Branches ? 0
=========================================
Hits ? 15839
Misses ? 27426
Partials ? 2100 |
ping @tonistiigi PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
It looks like no one uses this function.