Fix FIFO, sockets and device files when run in user NS #36756
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit 617c352 "Don't create devices if in a user namespace" introduced check, which meant to skip mknod operation when run in user namespace, but instread skipped FIFO and socket files copy. Signed-off-by: Maxim Ivanov <ivanov.maxim@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #36756 +/- ##
=========================================
Coverage ? 34.93%
=========================================
Files ? 614
Lines ? 45645
Branches ? 0
=========================================
Hits ? 15944
Misses ? 27607
Partials ? 2094 |
AkihiroSuda
approved these changes
Apr 1, 2018
tonistiigi
approved these changes
Apr 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
commit 617c352 (#25672) "Don't create devices if in a user namespace"
introduced check, which meant to skip mknod operation when run
in user namespace, but instread skipped FIFO and socket files
copy.
Fixes #36622
Signed-off-by: Maxim Ivanov ivanov.maxim@gmail.com