Always make sysfs read-write with privileged #36808
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It does not make any sense to vary this based on whether the rootfs is read only. We removed all the other mount dependencies on read-only eg see moby#35344. Signed-off-by: Justin Cormack <justin.cormack@docker.com>
justincormack
force-pushed
the
sys-rw-priv-always
branch
from
749351b to
a729853
Compare
Codecov Report
@@ Coverage Diff @@
## master #36808 +/- ##
=========================================
Coverage ? 34.93%
=========================================
Files ? 614
Lines ? 45648
Branches ? 0
=========================================
Hits ? 15947
Misses ? 27607
Partials ? 2094 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It does not make any sense to vary this based on whether the
rootfs is read only. We removed all the other mount dependencies
on read-only eg see #35344.
Signed-off-by: Justin Cormack justin.cormack@docker.com