Codecov Report

Merging #36894 into master will decrease coverage by 0.32%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #36894      +/-   ##
==========================================
- Coverage   35.26%   34.94%   -0.33%     
==========================================
  Files         614      614              
  Lines       45698    45698              
==========================================
- Hits        16117    15969     -148     
- Misses      27453    27633     +180     
+ Partials     2128     2096      -32

LGTM

I wonder is anything bad can happen if we do s/"golang.org/x/net/context"/"context"/ across the codebase?

I think there's still dependencies that use the /x/net/context, but we can check if that changed

We should be able to change it since in the new x/net/context, context.Context just a type alias.

The reason it was an issue before is because there were two different implementations of Context, one in the stdlib and one in x/net/context... so with this interface...

import "golang.org/x/net/context"
type Fooer interface {
    Foo(ctx context.Context)
}

You can't provide an implementation that looks like this:

import "context"

type myFoo struct {}

func(myFoo) Foo(ctx context.Context) {}

Until this bumped commit which takes advantage of https://github.com/golang/proposal/blob/master/design/18130-type-alias.md

Where context in golang.org/x/net is no longer defining a new interface but rather just doing:

"import context"

type Context = context.Context

In that case, I'd say we should definitely look into using "context" instead 🤗

OK, let's see if this works: #36904