Skip to content

Add windows recycle bin test and update hcsshim to v0.6.11 #36994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 4, 2018

Conversation

johnstep
Copy link
Member

@johnstep johnstep commented May 3, 2018

These changes update hcsshim to v0.6.11 (to perform a case-insensitive file name comparison when checking for $Recycle.Bin) and add integration tests to verify three things:

  1. The case of $Recycle.Bin does not prevent hcsshim from skipping it.
  2. The $Recycle.Bin directory is not committed to images.
  3. No files are missing after $Recycle.Bin; see Layers go missing between RUN statements docker/for-win#1947.

johnstep added 2 commits May 3, 2018 13:36
Signed-off-by: John Stephens <johnstep@docker.com>
Signed-off-by: John Stephens <johnstep@docker.com>
Copy link
Member

@lowenna lowenna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented May 4, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@e890301). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master   #36994   +/-   ##
=========================================
  Coverage          ?   35.08%           
=========================================
  Files             ?      615           
  Lines             ?    45780           
  Branches          ?        0           
=========================================
  Hits              ?    16062           
  Misses            ?    27610           
  Partials          ?     2108

Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah thaJeztah merged commit e2d3bb3 into moby:master May 4, 2018
@johnstep johnstep deleted the add-windows-recycle-bin-test branch July 13, 2018 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants