add api version checking for tests from new feature #37169
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AntaresS
force-pushed
the
add-version-checking
branch
from
63a841c to
632441c
Compare
Signed-off-by: Anda Xu <anda.xu@docker.com>
AntaresS
force-pushed
the
add-version-checking
branch
from
632441c to
8ed0fde
Compare
Codecov Report
@@ Coverage Diff @@
## master #37169 +/- ##
=======================================
Coverage 35.05% 35.05%
=======================================
Files 615 615
Lines 45828 45828
=======================================
Hits 16065 16065
- Misses 27652 27653 +1
+ Partials 2111 2110 -1 |
vdemeester
added
status/4-merge
rebuild/windowsRS1
and removed
status/2-code-review
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Anda Xu anda.xu@docker.com
- What I did
service_test.gofor new tests introduced with Allow user to specify default address pools for docker networks #36396- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)