-
Notifications
You must be signed in to change notification settings - Fork 18.7k
update fsnotify to v1.4.7 #37392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update fsnotify to v1.4.7 #37392
Conversation
Fixes a possible deadlock on closing the watcher on kqueue Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
ping @cpuguy83 PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🐯
Janky https://jenkins.dockerproject.org/job/Docker-PRs/49957/console is failing on #34988 / #35039;
PowerPC https://jenkins.dockerproject.org/job/Docker-PRs-powerpc/10386/console as well;
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fixes a possible deadlock on closing the watcher on kqueue
Full diff: fsnotify/fsnotify@4da3e2c...v1.4.7
Relevant change: