Fix long startup on windows, with non-hns governed Hyper-V networks #37774
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Similar to a related issue where previously, private Hyper-V networks would each add 15 secs to the daemon startup, non-hns governed internal networks are reported by hns as network type "internal" which is not mapped to any network plugin (and thus we get the same plugin load retry loop as before). This issue hits Docker for Desktop because we setup such a network for the Linux VM communication. Signed-off-by: Simon Ferquel <simon.ferquel@docker.com>
|
SGTM, but I'd like our networking team to verify too. @dineshgovindasamy, PTAL. |
|
ping @dineshgovindasamy, any feedback on this one ? |
|
ping @vdemeester this PR needs a bit of shaking. On Docker Desktop for Windows it adds 15 sec startup time per Hyper-V network not managed by HNS (on Windows 10 build 1803+). |
Codecov Report
@@ Coverage Diff @@
## master #37774 +/- ##
==========================================
- Coverage 36.09% 35.64% -0.45%
==========================================
Files 610 610
Lines 45115 46347 +1232
==========================================
+ Hits 16284 16521 +237
- Misses 26591 27559 +968
- Partials 2240 2267 +27 |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to a related issue where previously, private Hyper-V networks
would each add 15 secs to the daemon startup (see #33053), non-hns governed internal
networks are reported by hns as network type "internal" which is not
mapped to any network plugin (and thus we get the same plugin load retry
loop as before).
This issue hits Docker for Desktop because we setup such a network for
the Linux VM communication.
- What I did
Added "internal" in the list of network plugins skipped on windows startup sequence
- How I did it
Just modified an existing "if" block handling the "private" network type
- How to verify it