Skip to content

Add zero padding for RFC5424 syslog format #38335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 20, 2018

Conversation

yongtang
Copy link
Member

@yongtang yongtang commented Dec 8, 2018

This fix tries to address the issue raised in #38258
where current RFC5424 sys log format does not zero pad
the time (trailing zeros are removed)

This fix apply the patch to fix the issue. This fix fixes #38258.

Signed-off-by: Yong Tang yong.tang.github@outlook.com

This fix tries to address the issue raised in 38258
where current RFC5424 sys log format does not zero pad
the time (trailing zeros are removed)

This fix apply the patch to fix the issue. This fix fixes 38258.

Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@codecov
Copy link

codecov bot commented Dec 19, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@edf5134). Click here to learn what that means.
The diff coverage is 0%.

@@            Coverage Diff            @@
##             master   #38335   +/-   ##
=========================================
  Coverage          ?   36.57%           
=========================================
  Files             ?      610           
  Lines             ?    45275           
  Branches          ?        0           
=========================================
  Hits              ?    16559           
  Misses            ?    26388           
  Partials          ?     2328

Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐯

@vdemeester vdemeester merged commit b33dc72 into moby:master Dec 20, 2018
@yongtang yongtang deleted the 38258-syslog-rfc5424 branch December 20, 2018 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] RFC5424 fixed width in syslog
4 participants