Use MemAvailable instead of MemFree to estimate actual available memory #39481
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kenta Tada <Kenta.Tada@sony.com>
|
LGTM |
Codecov Report
@@ Coverage Diff @@
## master #39481 +/- ##
=========================================
Coverage ? 37.31%
=========================================
Files ? 609
Lines ? 45229
Branches ? 0
=========================================
Hits ? 16876
Misses ? 26063
Partials ? 2290 |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kenta Tada Kenta.Tada@sony.com
- What I did
I used MemAvailable instead of MemFree when Linux kernel supports it. Linux kernel version >=3.14 shows how much memory is actually available via MemAvailable.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=34e431b0ae398fc54ea69ff85ec700722c9da773
- How I did it
I modified parseMemInfo method to handle MemAvailable from "/proc/meminfo"
- How to verify it
I modified "meminfo_unix_test.go" to test whether this change can handle MemAvailable
- Description for the changelog
Use MemAvailable instead of MemFree to estimate actual available memory
- A picture of a cute animal (not mandatory but encouraged)