Skip to content

builder-next: close progress on layer export error #39782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 22, 2019
Merged

builder-next: close progress on layer export error #39782

merged 1 commit into from
Aug 22, 2019

Conversation

tonistiigi
Copy link
Member

Close progress on layer export error instead of leaving the build hanging.

Signed-off-by: Tonis Tiigi tonistiigi@gmail.com

@tonistiigi
builder-next: close progress on layer export error
27f1f2b 
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
thaJeztah
thaJeztah approved these changes Aug 22, 2019
View reviewed changes
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah
Copy link
Member

Windows failure is unrelated

02:11:55 SKIP: docker_cli_run_test.go:423: DockerSuite.TestRunCreateVolumesInSymlinkDir2 (unmatched requirement DaemonIsLinux)
02:11:57 
02:11:57 ----------------------------------------------------------------------
02:11:57 FAIL: check_test.go:107: DockerSuite.TearDownTest
02:11:57 
02:11:57 assertion failed: error is not nil: Error response from daemon: container e8e2af0092363babd6e2f26420c682289423bd110006f0a58e78ba12a2ea3dad: driver "windowsfilter" failed to remove root filesystem: failed to detach VHD: The device is not ready.: rename D:\CI\CI-27f1f2b5be\daemon\windowsfilter\e8e2af0092363babd6e2f26420c682289423bd110006f0a58e78ba12a2ea3dad D:\CI\CI-27f1f2b5be\daemon\windowsfilter\e8e2af0092363babd6e2f26420c682289423bd110006f0a58e78ba12a2ea3dad-removing: Access is denied.: failed to remove e8e2af0092363babd6e2f26420c682289423bd110006f0a58e78ba12a2ea3dad
02:11:57 
02:11:57 ----------------------------------------------------------------------
02:11:57 PANIC: docker_cli_run_test.go:4152: DockerSuite.TestRunCredentialSpecFailures
02:11:57 
02:11:57 ... Panic: Fixture has panicked (see related PANIC)

https://jenkins.dockerproject.org/job/Docker-PRs-WoW-RS1/26562/console

@thaJeztah thaJeztah merged commit d45f4cf into moby:master Aug 22, 2019
@tiborvass tiborvass mentioned this pull request Aug 22, 2019
Merged
@thaJeztah thaJeztah added this to the 20.03.0 milestone Apr 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiborvass tiborvass tiborvass approved these changes

@thaJeztah thaJeztah thaJeztah approved these changes

Assignees
No one assigned
Labels
area/builder process/cherry-picked status/2-code-review
Projects
None yet
Milestone
20.10.0
Development

Successfully merging this pull request may close these issues.
4 participants
@tonistiigi @thaJeztah @tiborvass @GordonTheTurtle