Skip to content

[20.10 backport] dockerd-rootless-setuptool.sh: create CLI context "rootless" #42109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 7, 2021
Merged

[20.10 backport] dockerd-rootless-setuptool.sh: create CLI context "rootless" #42109

merged 1 commit into from
Apr 7, 2021

Conversation

AkihiroSuda
Copy link
Member

Cherry-pick #42084

@AkihiroSuda
dockerd-rootless-setuptool.sh: create CLI context "rootless"
98273a6 
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
(cherry picked from commit f2f1c0f)
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
@thaJeztah thaJeztah added this to the 20.10.5 milestone Mar 3, 2021
@thaJeztah thaJeztah added area/rootless Rootless mode impact/changelog kind/enhancement Enhancements are not bugs or new features but can improve usability or performance. status/2-code-review docs/revisit impact/documentation labels Mar 3, 2021
@thaJeztah
Copy link
Member

note: once this is merged and shipped, we'll needs to update the documentation as well, to mention the new context that's created

thaJeztah
thaJeztah approved these changes Mar 3, 2021
View reviewed changes
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AkihiroSuda AkihiroSuda requested a review from tianon March 10, 2021 04:39
@thaJeztah thaJeztah modified the milestones: 20.10.5, 20.10.6 Mar 12, 2021
@AkihiroSuda
Copy link
Member Author

@tonistiigi @tiborvass PTAL? 🙏

@tiborvass tiborvass merged commit 94854bc into moby:20.10 Apr 7, 2021
@AkihiroSuda AkihiroSuda mentioned this pull request Apr 14, 2021
Merged
@thaJeztah
Copy link
Member

Removed the docs/revisit label as docker/docs#12674 has been opened

@AkihiroSuda AkihiroSuda mentioned this pull request Nov 16, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiborvass tiborvass tiborvass approved these changes

@thaJeztah thaJeztah thaJeztah approved these changes

@tianon tianon Awaiting requested review from tianon

@tonistiigi tonistiigi Awaiting requested review from tonistiigi

Assignees
No one assigned
Labels
area/rootless Rootless mode impact/changelog impact/documentation kind/enhancement Enhancements are not bugs or new features but can improve usability or performance. status/2-code-review
Projects
None yet
Milestone
20.10.6
Development

Successfully merging this pull request may close these issues.
3 participants
@AkihiroSuda @thaJeztah @tiborvass