[20.10 backport] vendor: docker/libnetwork b3507428be5b458cb0e2b4086b13531fb0706e46 #42205
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The normalizing was updated with the output of the "docker port" command
in mind, but we're normalizing the "expected" output, which is passed
without the "->" in front of the mapping, causing some tests to fail;
=== RUN TestDockerSuite/TestPortHostBinding
--- FAIL: TestDockerSuite/TestPortHostBinding (1.21s)
docker_cli_port_test.go:324: assertion failed: error is not nil: |:::9876!=[::]:9876|
=== RUN TestDockerSuite/TestPortList
--- FAIL: TestDockerSuite/TestPortList (0.96s)
docker_cli_port_test.go:25: assertion failed: error is not nil: |:::9876!=[::]:9876|
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
(cherry picked from commit c8599a6)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
full diff: moby/libnetwork@fa125a3...b350742 - fixed IPv6 iptables rules for enabled firewalld (libnetwork#2609) - fixes "Docker uses 'iptables' instead of 'ip6tables' for IPv6 NAT rule, crashes" - Fix regression in docker-proxy - introduced in "Fix IPv6 Port Forwarding for the Bridge Driver" (libnetwork#2604) - fixes/addresses: "IPv4 and IPv6 addresses are not bound by default anymore" (libnetwork#2607) - fixes/addresses "IPv6 is no longer proxied by default anymore" (moby#41858) - Use hostIP to decide on Portmapper version - fixes docker-proxy not being stopped correctly Port mapping of containers now contain separatet mappings for IPv4 and IPv6 addresses, when listening on "any" IP address. Various tests had to be updated to take multiple mappings into account. Signed-off-by: Sebastiaan van Stijn <github@gone.nl> (cherry picked from commit 0450728) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
added
status/2-code-review
area/networking
impact/changelog
kind/bugfix
5 tasks
AkihiroSuda
approved these changes
Mar 30, 2021
tiborvass
approved these changes
Apr 1, 2021
|
@thaJeztah Hello Sebastian! Could you properly tag the latest 20.10.6 release? https://github.com/moby/moby/releases |
|
Looks like it's tagged; https://github.com/moby/moby/releases/tag/v20.10.6 |
|
ok; added a GitHub release https://github.com/moby/moby/releases/tag/v20.10.6 |
|
After update to 20.10.06 issue happened again on CentOS 7.9 with ipv6 disabled (I really do not need it) - any ideea how to fix it? |
4 tasks
buildroot-auto-update
pushed a commit
to buildroot/buildroot
that referenced
this pull request
May 2, 2021
Fixes various networking issues: - Fix a regression in docker 20.10, causing IPv6 addresses no longer to be bound by default when mapping ports moby/moby#42205 - Fix implicit IPv6 port-mappings not included in API response. Before docker 20.10, published ports were accessible through both IPv4 and IPv6 by default, but the API only included information about the IPv4 (0.0.0.0) mapping moby/moby#42205 - Fix a regression in docker 20.10, causing the docker-proxy to not be terminated in all cases moby/moby#42205 - Fix iptables forwarding rules not being cleaned up upon container removal moby/moby#42205 For more details, see the release notes: https://docs.docker.com/engine/release-notes/#20106 Signed-off-by: Mario Fink <knif.oiram@gmail.com> Tested-by: Christian Stewart <christian@paral.in> Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
buildroot-auto-update
pushed a commit
to buildroot/buildroot
that referenced
this pull request
May 7, 2021
Fixes various networking issues: - Fix a regression in docker 20.10, causing IPv6 addresses no longer to be bound by default when mapping ports moby/moby#42205 - Fix implicit IPv6 port-mappings not included in API response. Before docker 20.10, published ports were accessible through both IPv4 and IPv6 by default, but the API only included information about the IPv4 (0.0.0.0) mapping moby/moby#42205 - Fix a regression in docker 20.10, causing the docker-proxy to not be terminated in all cases moby/moby#42205 - Fix iptables forwarding rules not being cleaned up upon container removal moby/moby#42205 For more details, see the release notes: https://docs.docker.com/engine/release-notes/#20106 Signed-off-by: Mario Fink <knif.oiram@gmail.com> Tested-by: Christian Stewart <christian@paral.in> Signed-off-by: Peter Korsgaard <peter@korsgaard.com> (cherry picked from commit e1458fe) Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of #41908
also somewhat related to #28589, which discusses the "implicit" binding of IPv6
depends on:
[DNM] trigger CI with rootlesskit v0.14.0-pre #42102update rootlesskit to v0.14.0 #42179 update rootlesskit to v0.14.0full diff: moby/libnetwork@fa125a3...b350742
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)