Skip to content

[Gloucester] Added cobrand front-end #5295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

lucascumsille
Copy link
Contributor

@lucascumsille lucascumsille commented Dec 10, 2024

Fixes: https://github.com/mysociety/societyworks/issues/4610

It includes:

  • Logos
  • Fonts
  • Emails
  • Colours
  • Navigation bar
  • favicon
  • Site message

Desktop

Screen.Recording.2024-12-10.at.10.40.57.mov
Screen.Recording.2024-12-10.at.10.41.28.mov
Screen.Recording.2024-12-10.at.10.41.55.mov

Mobile

Screen.Recording.2024-12-10.at.10.47.12.mov

Emails

Screenshot 2024-12-10 at 10 42 38 Screenshot 2024-12-10 at 10 43 10

[skip changelog]

Copy link

codecov bot commented Dec 10, 2024

Codecov Report

Attention: Patch coverage is 21.05263% with 15 lines in your changes missing coverage. Please review.

Project coverage is 82.28%. Comparing base (685e45e) to head (085764a).

Files with missing lines Patch % Lines
perllib/FixMyStreet/Cobrand/Gloucester.pm 22.22% 14 Missing ⚠️
perllib/FixMyStreet/Cobrand/FixMyStreet.pm 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5295      +/-   ##
==========================================
- Coverage   82.31%   82.28%   -0.04%     
==========================================
  Files         428      429       +1     
  Lines       34134    34153      +19     
  Branches     5513     5514       +1     
==========================================
+ Hits        28099    28103       +4     
- Misses       4402     4417      +15     
  Partials     1633     1633              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lucascumsille
Copy link
Contributor Author

Hi @chrismytton just in case I deleted most of the files that are not yet necessary, but I didn't delete the following:

  • assets,js
  • tracking_code.html
  • footer_extra_js.html

Those ones have the same info as Gloucestershire

@chrismytton
Copy link
Member

@lucascumsille Thanks! Will have a proper look at this next week and get it onto staging 🙂

@chrismytton chrismytton force-pushed the gloucester-front-end branch 5 times, most recently from 8b2c00d to d1f60dd Compare December 19, 2024 10:33
@chrismytton
Copy link
Member

I've deployed this to staging so now waiting to see if the client has any feedback.

lucascumsille and others added 2 commits April 15, 2025 12:46
It includes

- Logos
- Fonts
- Emails
- Colours
- Navigation bar
- favicon
- Site message
@chrismytton chrismytton force-pushed the gloucester-front-end branch from 2cf0f5f to 085764a Compare April 15, 2025 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants