Skip to content

[Bexley][WW] Allow modification of subscriptions #5374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

davea
Copy link
Member

@davea davea commented Feb 18, 2025

Copy link

codecov bot commented Feb 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.80%. Comparing base (17e25c6) to head (a292a13).
Report is 50 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5374      +/-   ##
==========================================
+ Coverage   82.28%   82.80%   +0.51%     
==========================================
  Files         426      428       +2     
  Lines       33575    34990    +1415     
  Branches     5412     5862     +450     
==========================================
+ Hits        27628    28973    +1345     
- Misses       4344     4377      +33     
- Partials     1603     1640      +37     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@davea davea force-pushed the bexley-ww-ggw-show-existing branch 2 times, most recently from 00c4c20 to 07c25ad Compare February 21, 2025 12:27
@davea davea force-pushed the bexley-ww-ggw-show-existing branch 2 times, most recently from aad5680 to e6dd83c Compare February 28, 2025 20:43
@dracos
Copy link
Member

dracos commented Mar 6, 2025

(This is only the last commit, and is out of date compared with upstream)

@davea davea force-pushed the bexley-ww-ggw-amend branch from 5733da7 to 047af30 Compare March 11, 2025 15:29
@davea davea changed the base branch from bexley-ww-ggw-show-existing to master March 11, 2025 15:29
@nephila-nacrea nephila-nacrea self-assigned this Mar 26, 2025
@nephila-nacrea nephila-nacrea force-pushed the bexley-ww-ggw-amend branch 2 times, most recently from a76720e to 0d99c5b Compare April 1, 2025 08:58
Copy link
Member

@chrismytton chrismytton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments on your comments, but the code all looks good!

@chrismytton chrismytton mentioned this pull request Apr 20, 2025
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants