Limit the max-width for sign-in form on mobile #5392
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added max-width to body.authpage .content, this should prevent it from using the whole screen width.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5392 +/- ##
==========================================
+ Coverage 82.42% 83.45% +1.03%
==========================================
Files 417 428 +11
Lines 33125 36919 +3794
Branches 5340 6240 +900
==========================================
+ Hits 27302 30810 +3508
- Misses 4234 4447 +213
- Partials 1589 1662 +73 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dracos
requested changes
Mar 14, 2025
| @@ -462,6 +462,7 @@ a.platform-logo { | |||
| body.authpage { | |||
| .content { | |||
| width: 27em; | |||
| max-width: 27em; | |||
There was a problem hiding this comment.
Can we drop the width line then; don't think it needs both?
There was a problem hiding this comment.
@dracos I just did =), let me know if you are happy for me to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: https://github.com/mysociety/societyworks/issues/4078
Preview:
Screen.Recording.2025-03-04.at.13.51.31.mov