Skip to content

[Bexley] WIP fetch sub from WW DB if not in Agile #5396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: bexley-ww-garden-reviewed
Choose a base branch
from

Conversation

davea
Copy link
Member

@davea davea commented Mar 5, 2025

In case a new sub hasn't yet been sent to Agile for whatever reason, we want to display it on the property's bin days page.

Copy link

codecov bot commented Mar 5, 2025

Codecov Report

Attention: Patch coverage is 85.71429% with 4 lines in your changes missing coverage. Please review.

Project coverage is 82.30%. Comparing base (0e14fc1) to head (0643682).

Files with missing lines Patch % Lines
perllib/FixMyStreet/Cobrand/Bexley/Garden.pm 85.71% 4 Missing ⚠️
Additional details and impacted files
@@                      Coverage Diff                      @@
##           bexley-ww-garden-reviewed    #5396      +/-   ##
=============================================================
- Coverage                      82.31%   82.30%   -0.02%     
=============================================================
  Files                            425      425              
  Lines                          33518    33532      +14     
  Branches                        5403     5408       +5     
=============================================================
+ Hits                           27590    27597       +7     
- Misses                          4330     4337       +7     
  Partials                        1598     1598              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mysociety-pusher mysociety-pusher force-pushed the bexley-ww-garden-reviewed branch from 4b0d737 to bdf7cf4 Compare March 6, 2025 14:20
@dracos dracos force-pushed the bexley-ww-garden-reviewed branch from bdf7cf4 to ae79bb5 Compare March 6, 2025 14:33
@dracos dracos force-pushed the bexley-ww-ggw-double-cancellation-check branch from 1c0805c to 0643682 Compare March 6, 2025 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant