[Bristol] Include staff user in title attribute. #5477
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5477 +/- ##
==========================================
- Coverage 82.36% 82.36% -0.01%
==========================================
Files 430 430
Lines 34156 34156
Branches 5521 5521
==========================================
- Hits 28133 28132 -1
Misses 4380 4380
- Partials 1643 1644 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
MorayMySoc
approved these changes
Apr 24, 2025
t/cobrand/bristol.t
Outdated
| subtest 'staff user added to title attribute' => sub { | ||
| my $req = Open311->test_req_used; | ||
| my $cgi = CGI::Simple->new($req->content); | ||
| is $cgi->param('attribute[title]'), "Staff User - Role\r\n\r\nTitle Test 1 for 1"; |
There was a problem hiding this comment.
Test failing here for test suite as no longer '1 for 1'
This means it will appear at the top of the full details attribute in their backend.
dracos
force-pushed
the
fd-5244-bristol-staff-reports
branch
from
10ecc3e to
b54663c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For https://mysocietysupport.freshdesk.com/a/tickets/5244
[skip changelog]