Skip to content

[Bristol] Add FMS reference to emails #5479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[Bristol] Add FMS reference to emails #5479

wants to merge 1 commit into from

Conversation

MorayMySoc
Copy link
Contributor

@MorayMySoc MorayMySoc commented Apr 25, 2025 •
edited
Loading

@MorayMySoc MorayMySoc requested a review from dracos April 25, 2025 11:04
@codecov Codecov
Copy link

codecov bot commented Apr 25, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.36%. Comparing base (b115619) to head (4b3bcb3).

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #5479      +/-   ##
==========================================
- Coverage   82.36%   82.36%   -0.01%     
==========================================
  Files         430      430              
  Lines       34156    34156              
  Branches     5521     5521              
==========================================
- Hits        28133    28132       -1     
  Misses       4380     4380              
- Partials     1643     1644       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

dracos
dracos approved these changes Apr 25, 2025
View reviewed changes
Copy link
Member

@dracos dracos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Perhaps (not now) we should think about having a config value for whether to include this or not, or something else like that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dracos dracos dracos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MorayMySoc @dracos