Add support for local files, even without arguments (fix #35) #41
Conversation
I think it's fix for nicojeske#35 Now all of those links are correct: C:\...\image.png C:\...\image.png? C:\...\image.png?123 file:\\C:\...\image.png file:\\C:\...\image.png? file:\\C:\...\image.png?123
Mideks
changed the title
Mideks
changed the title
|
Your approach handles these local files but then fails to recognize images that were embedded via the Obsidian Syntax (i.e. ![[image.jpg]]). These image get a path ending with a query parameter e.g. Your regex includes the query part so the function would return I will add a commit with a new Regex that (hopefully) covers all cases. I think we can safely disregard the handling of query parameters for local files as |
Introduce a regex that also works on local files. Local files also support the usage of either / or \ in the path.
|
Hmm, really missed that way of attaching files when I was testing. And I was thinking "why would a file path even have a construct with arguments...?". Turns out that's why :) |
I think it's fix for #35
Now all of those links are correct:
C:...\image.png
C:...\image.png?
C:...\image.png?123
file:\C:...\image.png
file:\C:...\image.png?
file:\C:...\image.png?123