Implement zooming functionality for all canvas nodes #48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Enable proportional scaling of all media attachments (images, videos, audio, PDFs), text blocks, and even Markdown files on the canvas using modifier key + mouse wheel, provided that these elements are not selected or focused for editing. - Introduce the ability to undo node scaling via ctrl+z, as if you were undoing the scaling action performed with the mouse. Note: Due to ongoing issue nicojeske#47, normal scaling is temporarily restricted to use with the Alt key. Related to: nicojeske#37
Moving away from deprecated code and fix typing errors (unfortunately by setting the types to any... as there are not type definitions for canvas yet...)
Partly fixes nicojeske#47. We now also disable scrolling on the `wheel` event if we hover over a canvas element, canvas node or image. This way we still scroll a little bit before the wheel event disables the scrolling but at least we stop scrolling indefinetly.
|
Sorry for just now looking at your PR. I tested it and the zooming on the canvas works as expected! I just did minor changes to remove deprecated warnings and fix typing (unfortunately by just spamming I also added a little workaround for the problem in #47 that is not perfect, but should at least be usable. |
Closed
Huh, yes. I did not find any documentation for canvas and I just reverseenering these canvas functions... I can't say it is was easy, but it was an interesting experience. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Due to ongoing issue #47, normal scaling is temporarily restricted to use with the Alt key.
Related to: #37