Skip to content

Add xml matching test #228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 24, 2025
Merged

Add xml matching test #228

merged 2 commits into from
Apr 24, 2025

Conversation

TTWNO
Copy link
Member

@TTWNO TTWNO commented Mar 11, 2025

  • Based on last section of interface, use zbus_xml to read either "Cache.xml", "Socket.xml" or "Registry.xml".
  • In the case where it matches neither of those, use "Event.xml".
  • Runs as part of the event_test_cases! macro.
  • Checks that both the interface exists in its associated file, and that the member also exists.
  • Since signature validation is done seperately, this was not checked as part of this test.

We may want to consider adding a way for zbus_lockstep to do this instead, but this is a good step forward for now.

Copy link

codecov bot commented Mar 11, 2025

Codecov Report

Attention: Patch coverage is 73.33333% with 4 lines in your changes missing coverage. Please review.

Project coverage is 81.55%. Comparing base (7cd7b5a) to head (db62794).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
atspi-common/src/macros.rs 73.33% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #228      +/-   ##
==========================================
- Coverage   81.58%   81.55%   -0.04%     
==========================================
  Files          43       43              
  Lines        3894     3909      +15     
==========================================
+ Hits         3177     3188      +11     
- Misses        717      721       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

- Based on ending of interface, use `zbus_xml` to read either "Cache.xml", "Socket.xml" or "Registry.xml".
- In the case where it matches neither of those, use "Event.xml".
- Runs as part of the `event_test_cases!` macro.
- Checks that both the interface exists in its associated file, and that the member also exists.
- Since signature validation is done seperately, this was not checked as part of this test.
@TTWNO TTWNO requested a review from luukvanderduim April 1, 2025 16:57
@TTWNO TTWNO merged commit b5c857b into main Apr 24, 2025
12 of 14 checks passed
@TTWNO TTWNO deleted the more-tests branch April 24, 2025 19:15
@TTWNO TTWNO restored the more-tests branch April 26, 2025 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant