-
Notifications
You must be signed in to change notification settings - Fork 14
improve aws profile autocomplete #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
look in config also; merge findings and return unique ones;
This could also be written , for Fish v3, as: cat ~/.aws/{config,credentials} | string replace -r -f "^\[(profile[[:space:]]*)*(.*)\]" '$2' | sort -u |
Any update on this? The above code seems to work fine... what do we need to get it merged in? 🙏 |
Hey, @rohan-buchner. Thanks for the ping regarding this PR. I've took the liberty of updating it, as you can see. I would appreciate if you could give it a try and let me know if it works as expected. Also let me know in case you need help testing this PR on your local/testing environment. Thanks! |
@scorphus the profiles below are all in the Screen.Recording.2022-03-03.at.14.27.48.movFWIW, I was not too sure how to test these dev plugin versions |
Can we merge this ? 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for contributing, @sanyer!
Thanks for the nudge, @Jomik |
oh wow, it's been a while now @scorphus |
search also ~/.aws/config file