Reduce runtime memory for multilang tts #1622
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spycsh
requested review from
lvliang-intel,
letonghan and
XinyaoWa
as code owners
Spycsh
force-pushed
the
reduce_runtime_memory
branch
from
c95f8f2 to
cd85605
Compare
4 tasks
eero-t
approved these changes
Apr 24, 2025
There was a problem hiding this comment.
Approved.
PS. AFAIK * pattern should skip dot files & dot dirs, so removing .git dir before mv is probably not needed. And because original repo dir is removed afterwards, .git dir history should also go away with it, so I think --depth arg addition actually affects only the Git repo download size, not final disk usage. It's still optimization, and I like this PR making extra data exclusion more explicit.
lvliang-intel
approved these changes
Apr 28, 2025
lvliang-intel
approved these changes
May 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reduce runtime memory for multilang tts
Remove the .git/ and histories from the downloaded HF model repo
Issues
na
Type of change
List the type of change like below. Please delete options that are not relevant.
Dependencies
na
Tests
ut