Helm chart for Ollama #774
Conversation
Signed-off-by: Jonathan Minkin <minkinj@amazon.com>
Signed-off-by: Jonathan Minkin <minkinj@amazon.com>
Signed-off-by: Jonathan Minkin <minkinj@amazon.com>
jonminkin97
force-pushed
the
chatqna-ollama-helm
branch
from
caa3e18 to
eae360d
Compare
Signed-off-by: Jonathan Minkin <minkinj@amazon.com>
There was a problem hiding this comment.
Thanks very much for contributing this. Besides the embedded comment, there is something missing in the helm template(e.g. HPA, service monitor). I would suggest you check https://github.com/opea-project/GenAIInfra/tree/main/helm-charts/common/lvm-serve to add the missing gap. Thanks!
Signed-off-by: Jonathan Minkin <minkinj@amazon.com>
Signed-off-by: Jonathan Minkin <minkinj@amazon.com>
Signed-off-by: Jonathan Minkin <minkinj@amazon.com>
Signed-off-by: Jonathan Minkin <minkinj@amazon.com>
Signed-off-by: Jonathan Minkin <minkinj@amazon.com>
Signed-off-by: Jonathan Minkin <minkinj@amazon.com>
|
@lianhao Thank you for the feedback. I've made the requested changes, and they are now pending your approval. Let me know if there are any other enhancements you would like to see. |
There was a problem hiding this comment.
2 more things beside the embedding comments:
-
Add a cpu-values.yaml file which is used to trigger the CI, just like what lvm-serve does. These kind of xxx-values contains additional configuration for CI to pass(could be empty if there no additional requirements at all).
-
Could you name this chart ollama instead of ollama-service? One of our 1.3 task is to make sure the helm chart name is consistent with the corresponding names in GenAIComps.
helm-charts/common/ollama-service/templates/servicemonitor.yaml
Outdated
Show resolved
Hide resolved
Signed-off-by: Jonathan Minkin <minkinj@amazon.com>
Signed-off-by: Jonathan Minkin <minkinj@amazon.com>
Signed-off-by: Jonathan Minkin <minkinj@amazon.com>
Signed-off-by: Jonathan Minkin <minkinj@amazon.com>
Signed-off-by: Jonathan Minkin <minkinj@amazon.com>
Signed-off-by: Jonathan Minkin <minkinj@amazon.com>
Description
Add Helm chart to deploy Ollama as a model server.
Issues
n/a
Type of change
List the type of change like below. Please delete options that are not relevant.
Dependencies
List the newly introduced 3rd party dependency if exists.
Tests
helm test [RELEASE]