Skip to content

Enable tiled ensembe in v2 #2660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 268 commits into
base: main
Choose a base branch
from
Open

Enable tiled ensembe in v2 #2660

wants to merge 268 commits into from

Conversation

blaz-r
Copy link
Contributor

@blaz-r blaz-r commented Apr 13, 2025 •
edited
Loading

📝 Description

  • This PR provides the refactor of the tiled ensemble for Anomalib V2.
  • 🛠️ Fixes [Task] Enable tiled ensembe in v2 #2625
  • I still need to update the docs, but the code + tests part is now ready for review.

✨ Changes

Select what type of change your PR is:

  • 🐞 Bug fix (non-breaking change which fixes an issue)
  • 🔨 Refactor (non-breaking change which refactors the code base)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 📚 Documentation update
  • 🔒 Security update

✅ Checklist

Before you submit your pull request, please make sure you have completed the following steps:

  • 📋 I have summarized my changes in the CHANGELOG and followed the guidelines for my type of change (skip for minor changes, documentation updates, and test enhancements).
  • 📚 I have made the necessary updates to the documentation (if applicable).
  • 🧪 I have written tests that support my changes and prove that my fix is effective or my feature works (if applicable).

For more information about code review checklists, see the Code Review Checklist.

blaz-r and others added 30 commits June 30, 2023 19:19
@blaz-r
Update tests for tiler
c8ecb6e
@blaz-r
Add training loop for ensemble
86c62c7
@blaz-r
Add model input size setup
f9bb615
@blaz-r
Move ens config to separate file
3e2dbda
@blaz-r
Revert mvtec modifications
28ea8a2
@blaz-r
Remove unused imports in mvtec
c321e60
@blaz-r
Add batch adjustment to untiling
cd90ef3
@blaz-r
Add predict step to ensemble
941439e
@blaz-r
Add comment and docstring to tile joining function
42023c6
@blaz-r
Move tile joining to separate function
69bd0e8
@blaz-r
Add joining for all tiled data
06eb042
@blaz-r
Add joining for all box data
67b9c3a
@blaz-r
Refactor pred. joining as modular class
94bc485
@blaz-r
Fix box joining
17b5655
@blaz-r
Merge branch 'openvinotoolkit:main' into ensemble
fc22440
@blaz-r
Add label and score joining
d1be665
@blaz-r
Merge remote-tracking branch 'origin/ensemble' into ensemble
752a749
@blaz-r
Add ensemble visualization
0a7b526
@blaz-r
Add end of predict hook
d091659
@blaz-r
Add metric computation
19d036e
@blaz-r
Fix metric thresholds
a607f73
@blaz-r
Add removal of individual visualization
62085de
@blaz-r
Add demo1 notebook
c81a612
@blaz-r
Add docstrings and cleanup
faf2839
@blaz-r
Add memory benchmark
a359b02
@blaz-r
Add modular class for storing predictions
326b304
@blaz-r
Add metric to separate class
6f2e789
@blaz-r
Refactor to support prediction data class
184bdb2
@blaz-r
Rename predictions class
f872303
@blaz-r
Add filesystem predictions class
d7ab2a5
blaz-r and others added 16 commits April 5, 2025 16:24
@blaz-r
Refactor pred. data and merging
d7998dc 
Signed-off-by: blaz-r <blaz.rolih@gmail.com>
@blaz-r
Initial train refactor
f792e9d 
Signed-off-by: blaz-r <blaz.rolih@gmail.com>
@blaz-r
Refactored working training
a05d289 
Signed-off-by: blaz-r <blaz.rolih@gmail.com>
@blaz-r
Fix merging missing items, shapes + add test.
8c3f55b 
Signed-off-by: blaz-r <blaz.rolih@gmail.com>
@blaz-r
Fix smoothing and tests
93b7946 
Signed-off-by: blaz-r <blaz.rolih@gmail.com>
@blaz-r
Fix stats comp and tests
5c4eaef 
Signed-off-by: blaz-r <blaz.rolih@gmail.com>
@blaz-r
Fix model input_size and tests
630c30f 
Signed-off-by: blaz-r <blaz.rolih@gmail.com>
@blaz-r
Fix norm, thresh and metrics
29080aa 
Signed-off-by: blaz-r <blaz.rolih@gmail.com>
@blaz-r
Refactor test pipeline
fb240e7 
Signed-off-by: blaz-r <blaz.rolih@gmail.com>
@blaz-r
Fix visualisation
53c8ea1 
Signed-off-by: blaz-r <blaz.rolih@gmail.com>
@blaz-r
Small fixes
ae95641 
Signed-off-by: blaz-r <blaz.rolih@gmail.com>
@blaz-r
Fix visualisation
7c8ae19 
Signed-off-by: blaz-r <blaz.rolih@gmail.com>
@blaz-r
Fix tests and some linting
f908e96 
Signed-off-by: blaz-r <blaz.rolih@gmail.com>
@blaz-r
Add lates config
9125516 
Signed-off-by: blaz-r <blaz.rolih@gmail.com>
@blaz-r
Merge branch 'open-edge-platform:main' into ensemble_v2
d8f1285
@blaz-r
Fix linter errors for tiled ensemble
0e3dc16 
Signed-off-by: blaz-r <blaz.rolih@gmail.com>
samet-akcay
samet-akcay reviewed Apr 14, 2025
View reviewed changes
Copy link
Contributor

@samet-akcay samet-akcay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Top quality changes, @blaz-r. Amazing work!
i only have minor comments regarding docstrings. It would be good to give credit to you and your work in the docstrings. Can you update them ?

@blaz-r
Copy link
Contributor Author

blaz-r commented Apr 14, 2025 •
edited
Loading

Okay, I'll address these things asap.
About the pre-commit failing, what exactly is the problem with these "Move into type-checking block"? I'm not sure why this even is an issue here, and not in let's say AnomalibModule.

Edit: I think it's because I'm only using these components as type annotations, so I'll fix that.

samet-akcay
samet-akcay requested changes Apr 14, 2025
View reviewed changes
Copy link
Contributor

@samet-akcay samet-akcay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've suggested the fixes for the pre-commit fail.

If you install Ruff extension to VS Code, or whatever you are using, it should automatically fix them.

To check these locally you could run the following:

pre-commit run -a

blaz-r added 5 commits April 14, 2025 20:21
@blaz-r
Fix type-checking errors
fe910db 
Signed-off-by: blaz-r <blaz.rolih@gmail.com>
@blaz-r
Fix torch.Tensor usage
327408e 
Signed-off-by: blaz-r <blaz.rolih@gmail.com>
@blaz-r
Add more details to docstrings.
ddc2d5d 
Signed-off-by: blaz-r <blaz.rolih@gmail.com>
@blaz-r
Fix MVTecAD class in ens config
972ece3 
Signed-off-by: blaz-r <blaz.rolih@gmail.com>
@blaz-r
Update tiled ensemble docs
3b6eeb2 
Signed-off-by: blaz-r <blaz.rolih@gmail.com>
@blaz-r
Copy link
Contributor Author

blaz-r commented Apr 14, 2025

I've updated the docstrings, fixed the linting and security errors, and updated the docs.

samet-akcay
samet-akcay reviewed Apr 14, 2025
View reviewed changes
Copy link
Contributor

@samet-akcay samet-akcay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks a lot for the upgrade!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samet-akcay samet-akcay samet-akcay approved these changes

@ashwinvaidya17 ashwinvaidya17 Awaiting requested review from ashwinvaidya17 ashwinvaidya17 is a code owner

@djdameln djdameln Awaiting requested review from djdameln djdameln is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Task] Enable tiled ensembe in v2
2 participants
@blaz-r @samet-akcay