@rioug I have requested the merge of the last master changes, and it seems that the Rubocop warning is gone, but now I have a test failing, it seems to be a flaky one. Do you know waht to do in this case? Can I trigger the checks without pushing a commit?

Can I trigger the checks without pushing a commit?

On your fork you should be able to, but probably not in the OFN repo, but I can :) All good now, thanks !

Hey @pacodelaluna , how are you 👋
Did you want to continue on this?

Hey @pacodelaluna , how are you 👋 Did you want to continue on this?

Hi @sigmundpetersen, yes sorry, I was quite busy lately, I will take a look at this asap.

@rioug I have added 2 tests for the new validation, please tell me if it is fine.

Looks good, thanks for adding the test !

Hey @pacodelaluna ,

I've tested the superadmin field External Billing ID, and tried to introduce white spaces. Doing so, triggers this validation error:

And does not change the previously introduced data, so that the ID remains without spaces. I've tested this for empty spaces in the:

• beginning of the ID: CU2412-00005
• middle of the ID: CU2412 00005
• end of the ID: CU2412_00005

Also tested removing the ID completely (deleting it), which is possible and works as before. Noticed though, that the report does not display none, as for other hubs, after a previously saved ID is deleted (notice the empty space on the column below):

This is not introduced by this PR. So, with the validation you've introduced, we can be sure that the ID does not have empty spaces 🎉

Merging.