Skip to content

chore: move ratatui crate into workspace folder #1459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Oct 31, 2024
Merged

chore: move ratatui crate into workspace folder #1459

merged 6 commits into from
Oct 31, 2024

Conversation

joshka
Copy link
Member

@joshka joshka commented Oct 30, 2024

This is the first step towards modularization. Handling the move
as a separate step rather than combining it should make it easier
to rebase other PRs when necessary.

@joshka joshka requested a review from a team as a code owner October 30, 2024 22:36
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 30, 2024 •
edited
Loading

🐰 Bencher Report

Branch1459/merge
Testbedubuntu-latest

⚠️ WARNING: The following Measure does not have a Threshold. Without a Threshold, no Alerts will ever be generated!

Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the --ci-only-thresholds CLI flag.

Click to view all benchmark results
BenchmarkLatencynanoseconds (ns)
barchart/render/2048📈 view plot
⚠️ NO THRESHOLD		201,600.00
barchart/render/256📈 view plot
⚠️ NO THRESHOLD		134,680.00
barchart/render/64📈 view plot
⚠️ NO THRESHOLD		88,422.00
barchart/render_grouped/2048📈 view plot
⚠️ NO THRESHOLD		346,650.00
barchart/render_grouped/256📈 view plot
⚠️ NO THRESHOLD		146,170.00
barchart/render_grouped/64📈 view plot
⚠️ NO THRESHOLD		134,410.00
barchart/render_horizontal/2048📈 view plot
⚠️ NO THRESHOLD		164,690.00
barchart/render_horizontal/256📈 view plot
⚠️ NO THRESHOLD		82,554.00
barchart/render_horizontal/64📈 view plot
⚠️ NO THRESHOLD		76,383.00
block/render_all_feature/100x50📈 view plot
⚠️ NO THRESHOLD		11,250.00
block/render_all_feature/200x50📈 view plot
⚠️ NO THRESHOLD		19,701.00
block/render_all_feature/256x256📈 view plot
⚠️ NO THRESHOLD		93,651.00
block/render_empty/100x50📈 view plot
⚠️ NO THRESHOLD		6,226.80
block/render_empty/200x50📈 view plot
⚠️ NO THRESHOLD		12,194.00
block/render_empty/256x256📈 view plot
⚠️ NO THRESHOLD		79,653.00
buffer/empty/16📈 view plot
⚠️ NO THRESHOLD		779.39
buffer/empty/255📈 view plot
⚠️ NO THRESHOLD		222,730.00
buffer/empty/64📈 view plot
⚠️ NO THRESHOLD		13,155.00
buffer/filled/16📈 view plot
⚠️ NO THRESHOLD		782.76
buffer/filled/255📈 view plot
⚠️ NO THRESHOLD		219,840.00
buffer/filled/64📈 view plot
⚠️ NO THRESHOLD		13,347.00
buffer/with_lines/16📈 view plot
⚠️ NO THRESHOLD		15,483.00
buffer/with_lines/255📈 view plot
⚠️ NO THRESHOLD		16,306.00
buffer/with_lines/64📈 view plot
⚠️ NO THRESHOLD		15,226.00
line_render/Center/0📈 view plot
⚠️ NO THRESHOLD		4.02
line_render/Center/10📈 view plot
⚠️ NO THRESHOLD		632.05
line_render/Center/3📈 view plot
⚠️ NO THRESHOLD		298.05
line_render/Center/4📈 view plot
⚠️ NO THRESHOLD		341.40
line_render/Center/42📈 view plot
⚠️ NO THRESHOLD		845.33
line_render/Center/6📈 view plot
⚠️ NO THRESHOLD		400.82
line_render/Center/7📈 view plot
⚠️ NO THRESHOLD		455.73
line_render/Left/0📈 view plot
⚠️ NO THRESHOLD		4.03
line_render/Left/10📈 view plot
⚠️ NO THRESHOLD		592.52
line_render/Left/3📈 view plot
⚠️ NO THRESHOLD		229.58
line_render/Left/4📈 view plot
⚠️ NO THRESHOLD		243.62
line_render/Left/42📈 view plot
⚠️ NO THRESHOLD		845.26
line_render/Left/6📈 view plot
⚠️ NO THRESHOLD		390.18
line_render/Left/7📈 view plot
⚠️ NO THRESHOLD		402.81
line_render/Right/0📈 view plot
⚠️ NO THRESHOLD		4.02
line_render/Right/10📈 view plot
⚠️ NO THRESHOLD		568.46
line_render/Right/3📈 view plot
⚠️ NO THRESHOLD		277.57
line_render/Right/4📈 view plot
⚠️ NO THRESHOLD		332.24
line_render/Right/42📈 view plot
⚠️ NO THRESHOLD		845.08
line_render/Right/6📈 view plot
⚠️ NO THRESHOLD		442.33
line_render/Right/7📈 view plot
⚠️ NO THRESHOLD		499.71
list/render/16384📈 view plot
⚠️ NO THRESHOLD		1,205,100.00
list/render/2048📈 view plot
⚠️ NO THRESHOLD		322,360.00
list/render/64📈 view plot
⚠️ NO THRESHOLD		201,630.00
list/render_scroll_half/16384📈 view plot
⚠️ NO THRESHOLD		1,218,500.00
list/render_scroll_half/2048📈 view plot
⚠️ NO THRESHOLD		323,700.00
list/render_scroll_half/64📈 view plot
⚠️ NO THRESHOLD		135,510.00
paragraph/new/2048📈 view plot
⚠️ NO THRESHOLD		255,120.00
paragraph/new/64📈 view plot
⚠️ NO THRESHOLD		6,751.20
paragraph/new/65535📈 view plot
⚠️ NO THRESHOLD		8,199,400.00
paragraph/render/2048📈 view plot
⚠️ NO THRESHOLD		616,870.00
paragraph/render/64📈 view plot
⚠️ NO THRESHOLD		574,040.00
paragraph/render/65535📈 view plot
⚠️ NO THRESHOLD		1,801,300.00
paragraph/render_scroll_full/2048📈 view plot
⚠️ NO THRESHOLD		584,250.00
paragraph/render_scroll_full/64📈 view plot
⚠️ NO THRESHOLD		610,750.00
paragraph/render_scroll_full/65535📈 view plot
⚠️ NO THRESHOLD		1,793,600.00
paragraph/render_scroll_half/2048📈 view plot
⚠️ NO THRESHOLD		584,970.00
paragraph/render_scroll_half/64📈 view plot
⚠️ NO THRESHOLD		617,130.00
paragraph/render_scroll_half/65535📈 view plot
⚠️ NO THRESHOLD		1,786,100.00
paragraph/render_wrap/2048📈 view plot
⚠️ NO THRESHOLD		286,100.00
paragraph/render_wrap/64📈 view plot
⚠️ NO THRESHOLD		242,300.00
paragraph/render_wrap/65535📈 view plot
⚠️ NO THRESHOLD		1,513,900.00
paragraph/render_wrap_scroll_full/2048📈 view plot
⚠️ NO THRESHOLD		284,890.00
paragraph/render_wrap_scroll_full/64📈 view plot
⚠️ NO THRESHOLD		242,610.00
paragraph/render_wrap_scroll_full/65535📈 view plot
⚠️ NO THRESHOLD		1,507,400.00
rect/rect_columns_collect/16📈 view plot
⚠️ NO THRESHOLD		39.05
rect/rect_columns_collect/255📈 view plot
⚠️ NO THRESHOLD		292.47
rect/rect_columns_collect/64📈 view plot
⚠️ NO THRESHOLD		90.89
rect/rect_columns_iter/16📈 view plot
⚠️ NO THRESHOLD		10.72
rect/rect_columns_iter/255📈 view plot
⚠️ NO THRESHOLD		84.15
rect/rect_columns_iter/64📈 view plot
⚠️ NO THRESHOLD		26.21
rect/rect_positions_collect/16x16📈 view plot
⚠️ NO THRESHOLD		293.54
rect/rect_positions_collect/255x255📈 view plot
⚠️ NO THRESHOLD		60,636.00
rect/rect_positions_collect/64x64📈 view plot
⚠️ NO THRESHOLD		3,869.70
rect/rect_positions_iter/16x16📈 view plot
⚠️ NO THRESHOLD		248.66
rect/rect_positions_iter/255x255📈 view plot
⚠️ NO THRESHOLD		60,353.00
rect/rect_positions_iter/64x64📈 view plot
⚠️ NO THRESHOLD		3,811.50
rect/rect_rows_collect/16📈 view plot
⚠️ NO THRESHOLD		37.39
rect/rect_rows_collect/255📈 view plot
⚠️ NO THRESHOLD		260.31
rect/rect_rows_collect/64📈 view plot
⚠️ NO THRESHOLD		82.55
rect/rect_rows_iter/16📈 view plot
⚠️ NO THRESHOLD		7.77
rect/rect_rows_iter/255📈 view plot
⚠️ NO THRESHOLD		80.55
rect/rect_rows_iter/64📈 view plot
⚠️ NO THRESHOLD		21.53
sparkline/render/2048📈 view plot
⚠️ NO THRESHOLD		126,130.00
sparkline/render/256📈 view plot
⚠️ NO THRESHOLD		124,500.00
sparkline/render/64📈 view plot
⚠️ NO THRESHOLD		39,232.00
table/render/16384x2📈 view plot
⚠️ NO THRESHOLD		2,856,400.00
table/render/16384x4📈 view plot
⚠️ NO THRESHOLD		5,417,400.00
table/render/16384x8📈 view plot
⚠️ NO THRESHOLD		16,212,000.00
table/render/2048x2📈 view plot
⚠️ NO THRESHOLD		631,940.00
table/render/2048x4📈 view plot
⚠️ NO THRESHOLD		1,084,700.00
table/render/2048x8📈 view plot
⚠️ NO THRESHOLD		1,794,400.00
table/render/64x2📈 view plot
⚠️ NO THRESHOLD		321,900.00
table/render/64x4📈 view plot
⚠️ NO THRESHOLD		499,720.00
table/render/64x8📈 view plot
⚠️ NO THRESHOLD		573,720.00
table/render_scroll_half/16384x2📈 view plot
⚠️ NO THRESHOLD		2,876,400.00
table/render_scroll_half/16384x4📈 view plot
⚠️ NO THRESHOLD		5,534,600.00
table/render_scroll_half/16384x8📈 view plot
⚠️ NO THRESHOLD		18,625,000.00
table/render_scroll_half/2048x2📈 view plot
⚠️ NO THRESHOLD		635,970.00
table/render_scroll_half/2048x4📈 view plot
⚠️ NO THRESHOLD		1,080,100.00
table/render_scroll_half/2048x8📈 view plot
⚠️ NO THRESHOLD		1,761,000.00
table/render_scroll_half/64x2📈 view plot
⚠️ NO THRESHOLD		206,560.00
table/render_scroll_half/64x4📈 view plot
⚠️ NO THRESHOLD		331,280.00
table/render_scroll_half/64x8📈 view plot
⚠️ NO THRESHOLD		376,120.00
🐰 View full continuous benchmarking report in Bencher

@joshka joshka mentioned this pull request Oct 31, 2024
Merged
This was referenced Oct 31, 2024
Closed
Open
@orhun
Copy link
Member

orhun commented Oct 31, 2024

Added CARGO_MAKE_EXTEND_WORKSPACE_MAKEFILE environment variable to Makefile.toml to fix the CI

orhun
orhun approved these changes Oct 31, 2024
View reviewed changes
Copy link
Member

@orhun orhun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Fixed the CI issues. There are some leftover things such as running certain cargo commands for all the workspace members but we can take a look at them in the followup PR I guess.

@joshka
Copy link
Member Author

joshka commented Oct 31, 2024 •
edited
Loading

Sweet - thanks for fixing that up. I'm going to play around with xtask to replace cargo make and will make sure to keep the need to run the right cargo commands for each package in mind.

@joshka joshka merged commit f1d0a18 into main Oct 31, 2024
40 checks passed
@joshka joshka deleted the jm/workspace branch October 31, 2024 21:59
This was referenced Nov 2, 2024
Closed
Merged
@HoKim98 HoKim98 mentioned this pull request Nov 12, 2024
Merged
This was referenced Feb 11, 2025
Merged
Open
@github-actions github-actions bot mentioned this pull request Feb 22, 2025
Open
This was referenced Mar 3, 2025
Open
Open
@github-actions github-actions bot mentioned this pull request Mar 25, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orhun orhun orhun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joshka @orhun