Skip to content

fix: rust 1.84 clippy lints #1612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 10, 2025
Merged

fix: rust 1.84 clippy lints #1612

merged 1 commit into from
Jan 10, 2025

Conversation

joshka
Copy link
Member

@joshka joshka commented Jan 10, 2025

The canvas map constants are now statics instead.
Fixes https://rust-lang.github.io/rust-clippy/master/index.html\#large_const_arrays

@joshka joshka requested a review from a team as a code owner January 10, 2025 01:11
Copy link

codecov bot commented Jan 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.8%. Comparing base (1798512) to head (704fd93).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #1612     +/-   ##
=======================================
- Coverage   92.9%   92.8%   -0.2%     
=======================================
  Files         76      76             
  Lines      17176   17098     -78     
=======================================
- Hits       15960   15869     -91     
- Misses      1216    1229     +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@orhun orhun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@orhun orhun merged commit a692a6e into main Jan 10, 2025
31 checks passed
@orhun orhun deleted the jm/fix-1.84-clippy branch January 10, 2025 20:17
This was referenced Feb 11, 2025
This was referenced Mar 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants