fix(hub): logs are not streamed when opening newly created actor #2015
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying rivet-hub with
|
| Latest commit: |
0640508
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://90b8bddb.rivet-hub-7jb.pages.dev |
| Branch Preview URL: | https://graphite-base-2016.rivet-hub-7jb.pages.dev |
This was referenced Feb 11, 2025
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR modifies the watch query mechanism in the Hub application, focusing on log streaming functionality for newly created actors.
- Added redundant
await query.promisein/frontend/apps/hub/src/queries/watch.tsthat could cause infinite loops by repeatedly awaiting the same promise - Potential race condition in watch loop where query state isn't properly updated between iterations
- Missing mechanism to refresh/update the promise reference between watch loop iterations
- Watch query state checking logic may prevent proper streaming initialization for new actors
The changes introduce potential performance and reliability issues in the actor log streaming implementation that should be addressed before merging.
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
Deploying rivet with
|
| Latest commit: |
0640508
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://43968e04.rivet.pages.dev |
| Branch Preview URL: | https://graphite-base-2016.rivet.pages.dev |
This was referenced Feb 11, 2025
jog1t
force-pushed
the
02-11-fix_hub_logs_are_not_streamed_when_opening_newly_created_actor
branch
from
f9b1104 to
0640508
Compare
jog1t
force-pushed
the
02-11-fix_hub_prevent_long_lines_to_break_the_layout
branch
from
82134dc to
63ec0e4
Compare
jog1t
changed the base branch from
02-11-fix_hub_prevent_long_lines_to_break_the_layout
to
graphite-base/2015
Merge activity
|
graphite-app bot
pushed a commit
that referenced
this pull request
Feb 17, 2025
<!-- Please make sure there is an issue that this PR is correlated to. --> Closes FRONT-620 ## Changes <!-- If there are frontend changes, please include screenshots. -->
graphite-app
bot
deleted the
02-11-fix_hub_logs_are_not_streamed_when_opening_newly_created_actor
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes FRONT-620
Changes