Skip to content

chore(cli): remove BuildAccess config #2208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

chore(cli): remove BuildAccess config #2208

wants to merge 1 commit into from

Conversation

NathanFlurry
Copy link
Member

Changes

This was referenced Mar 14, 2025
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@NathanFlurry Graphite App
Copy link
Member Author

NathanFlurry commented Mar 14, 2025 •
edited by jog1t
Loading

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

How to use the Graphite Merge Queue

Add the label merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@NathanFlurry NathanFlurry mentioned this pull request Mar 14, 2025
Closed
@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

Deploying rivet with  Cloudflare Pages  Cloudflare Pages

Latest commit: c6f0e58
Status:🚫  Build failed.

View logs

greptile-apps[bot]
greptile-apps bot reviewed Mar 14, 2025
View reviewed changes
Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This PR removes the BuildAccess configuration and its associated tags across the Rivet toolchain, simplifying the build configuration system.

  • Removed BuildAccess enum and its field from Build struct in /packages/toolchain/toolchain/src/config/mod.rs
  • Removed ACCESS constant from tags module in /packages/toolchain/toolchain/src/build.rs
  • Removed access field from build_publish::Input struct in /packages/toolchain/toolchain/src/tasks/build_publish/mod.rs
  • Removed unstable field containing manager configurations from Root struct in /packages/toolchain/toolchain/src/config/mod.rs

4 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

@NathanFlurry NathanFlurry force-pushed the 03-14-docs_cli_add_docs_for_all_remaining_commands branch from 9d13f5d to 67a8ef2 Compare March 14, 2025 22:15
@NathanFlurry NathanFlurry force-pushed the 03-14-chore_cli_remove_buildaccess_config branch from c6f0e58 to bf9a7d5 Compare March 14, 2025 22:15
@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

Deploying rivet-hub with  Cloudflare Pages  Cloudflare Pages

Latest commit: bf9a7d5
Status:⚡️  Build in progress...

View logs

@NathanFlurry NathanFlurry mentioned this pull request Mar 14, 2025
Closed
@graphite-app Graphite App
Copy link
Contributor

graphite-app bot commented Mar 14, 2025 •
edited
Loading

Merge activity

  • Mar 14, 6:17 PM EDT: A user added this pull request to the Graphite merge queue.
  • Mar 14, 6:18 PM EDT: CI is running for this pull request on a draft pull request (#2210) due to your merge queue CI optimization settings.
  • Mar 14, 6:19 PM EDT: A user merged this pull request with the Graphite merge queue via draft PR: #2210.

graphite-app bot pushed a commit that referenced this pull request Mar 14, 2025
@NathanFlurry
chore(cli): remove BuildAccess config (#2208)
81c62b5 
<!-- Please make sure there is an issue that this PR is correlated to. -->

## Changes

<!-- If there are frontend changes, please include screenshots. -->
@graphite-app graphite-app bot deleted the branch 03-14-docs_cli_add_docs_for_all_remaining_commands March 14, 2025 22:19
@graphite-app graphite-app bot closed this Mar 14, 2025
@graphite-app graphite-app bot closed this Mar 14, 2025
@graphite-app graphite-app bot deleted the 03-14-chore_cli_remove_buildaccess_config branch March 14, 2025 22:19
@github-actions github-actions bot mentioned this pull request Mar 14, 2025
Merged
This was referenced Mar 20, 2025
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greptile-apps greptile-apps[bot] greptile-apps[bot] left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@NathanFlurry