Skip to content

fix: fix pb draining #2136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

MasterPtato
Copy link
Contributor

Changes

Copy link

cloudflare-workers-and-pages bot commented Mar 6, 2025

Deploying rivet with  Cloudflare Pages  Cloudflare Pages

Latest commit: b2a20c5
Status:🚫  Build failed.

View logs

Copy link
Contributor Author

MasterPtato commented Mar 6, 2025

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more


How to use the Graphite Merge Queue

Add the label merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This PR enhances pegboard draining functionality and logging across multiple services. Here's a summary of the key changes:

  • Added warning log when no pegboard client ID exists during server drain operations in drain.rs
  • Simplified pegboard client registration by using client ID as server ID temporarily in client/mod.rs
  • Enhanced workflow activity logging with additional context (workflow name, ID, activity name) in workflow.rs
  • Removed redundant debug logging from actor allocation process in runtime.rs
  • Improved code readability through better SQL query formatting in fdb_sqlite_nats/mod.rs

The changes focus on improving observability and error handling while maintaining existing functionality. The temporary workaround for server ID handling should be revisited in the future.

6 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings | Greptile

Comment on lines 25 to 27
let cli = Cli::parse();


Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style: unnecessary blank line added

Comment on lines +479 to +481
// TODO: Get server id from init packet. For now because the pb client id is the same as the
// server id it doesn't matter
server_id: input.client_id,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style: This temporary workaround assumes client_id equals server_id. Consider adding validation to ensure this assumption holds true until the proper fix is implemented.

@MasterPtato MasterPtato force-pushed the 03-06-fix_fix_pb_draining branch from f0f166f to b2a20c5 Compare March 6, 2025 23:24
@MasterPtato MasterPtato force-pushed the 03-06-fix_fix_wf_change_bug_with_client_wf branch from f489dde to d625cea Compare March 6, 2025 23:24
Copy link

cloudflare-workers-and-pages bot commented Mar 6, 2025

Deploying rivet-hub with  Cloudflare Pages  Cloudflare Pages

Latest commit: b2a20c5
Status: ✅  Deploy successful!
Preview URL: https://b80ff8d8.rivet-hub-7jb.pages.dev
Branch Preview URL: https://03-06-fix-fix-pb-draining.rivet-hub-7jb.pages.dev

View logs

@MasterPtato MasterPtato force-pushed the 03-06-fix_fix_pb_draining branch from b2a20c5 to 3ce6b8f Compare March 7, 2025 01:40
@MasterPtato MasterPtato force-pushed the 03-06-fix_fix_wf_change_bug_with_client_wf branch from d625cea to 2c22f6b Compare March 7, 2025 01:40
Copy link
Contributor

graphite-app bot commented Mar 7, 2025

Merge activity

  • Mar 6, 8:43 PM EST: A user added this pull request to the Graphite merge queue.
  • Mar 6, 8:44 PM EST: CI is running for this PR on a draft PR: #2147
  • Mar 6, 8:45 PM EST: A user merged this pull request with the Graphite merge queue via draft PR: #2147.

graphite-app bot pushed a commit that referenced this pull request Mar 7, 2025
<!-- Please make sure there is an issue that this PR is correlated to. -->

## Changes

<!-- If there are frontend changes, please include screenshots. -->
@graphite-app graphite-app bot closed this Mar 7, 2025
@graphite-app graphite-app bot deleted the 03-06-fix_fix_pb_draining branch March 7, 2025 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant