-
Notifications
You must be signed in to change notification settings - Fork 85
fix: fix pb draining #2136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fix pb draining #2136
Conversation
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
How to use the Graphite Merge QueueAdd the label merge-queue to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
This PR enhances pegboard draining functionality and logging across multiple services. Here's a summary of the key changes:
- Added warning log when no pegboard client ID exists during server drain operations in
drain.rs
- Simplified pegboard client registration by using client ID as server ID temporarily in
client/mod.rs
- Enhanced workflow activity logging with additional context (workflow name, ID, activity name) in
workflow.rs
- Removed redundant debug logging from actor allocation process in
runtime.rs
- Improved code readability through better SQL query formatting in
fdb_sqlite_nats/mod.rs
The changes focus on improving observability and error handling while maintaining existing functionality. The temporary workaround for server ID handling should be revisited in the future.
6 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings | Greptile
let cli = Cli::parse(); | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
style: unnecessary blank line added
// TODO: Get server id from init packet. For now because the pb client id is the same as the | ||
// server id it doesn't matter | ||
server_id: input.client_id, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
style: This temporary workaround assumes client_id equals server_id. Consider adding validation to ensure this assumption holds true until the proper fix is implemented.
f0f166f
to
b2a20c5
Compare
f489dde
to
d625cea
Compare
Deploying rivet-hub with
|
Latest commit: |
b2a20c5
|
Status: | ✅ Deploy successful! |
Preview URL: | https://b80ff8d8.rivet-hub-7jb.pages.dev |
Branch Preview URL: | https://03-06-fix-fix-pb-draining.rivet-hub-7jb.pages.dev |
b2a20c5
to
3ce6b8f
Compare
d625cea
to
2c22f6b
Compare
Merge activity
|
<!-- Please make sure there is an issue that this PR is correlated to. --> ## Changes <!-- If there are frontend changes, please include screenshots. -->
Changes