Open
Description
Describe the bug
Using APNS with batched delivery, there is no notification_enqueued
reflection triggered when notifications are queued. This means that we don't have visibility into the state of notifications processing (only delivered/failed which is half of the story).
The issue is in the Rpush::Daemon::AppRunner#enqueue
method. When batch_deliveries?
is true reflect
is not called.
To Reproduce
Expected behavior
Even when using batched deliveries there should be a reflection which indicates that one or more notifications has been enqueued.
Logs and other output
{"time":"2024-11-21T23:05:30Z","level":"info","message":"[2024-11-21 15:05:30][change_app_ios_production] 36 sent to 78E8F237D5AAEDB5F4325E363CDF78245336630261E979CE6362484A04D8F4B0"}
{"time":"2024-11-21T23:05:30Z","level":"info","message":"[2024-11-21 15:05:30]XXX Received notification event: notification_delivered"}
{"time":"2024-11-21T23:05:30Z","level":"info","message":"[2024-11-21 15:05:30]XXX Decrementing enqueued_notifications_counter"}
{"time":"2024-11-21T23:05:30Z","level":"info","message":"[2024-11-21 15:05:30]XXX Incrementing notification_event_counter with event: notification_delivered"}
System configuration (please complete the following information):
- OS: MacOS
- OS version: 14.7.1
- Ruby version: 3.2.2
- Rails version: 7.2.1
- Rpush version: 7.0.1