Skip to content

[reflections] cleanup templates and documentation #722

Open
@josef-krabath

Description

@josef-krabath

Description
The rpush init rake task generates a default initializer for Rpush that includes sample code for various reflections. However, I believe some of these reflections are outdated and may have been removed in previous releases of the gem.

I just refactored the Rpush configuration of our apps and it took me a while to figure out that a couple of previously used reflections are not supported any more.

Suggestion
I can offer to remove the stale reflections from the code base and create a PR to:

  • cleanup the template for the Rails initializer (lib/generators/templates/rpush.rb)
  • cleanup the file lib/rpush/reflection_collection.rb
  • cleanup the README.md

Examples

[apns_feedback]
It seems like this reflection is no longer used. Instead, APNS apps use the reflection notification_id_failed in case of errors / stale device_tokens.

[fcm_canonical_id]
It seems like the reflection fcm_canonical_id is no longer invoked in the codebase.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions