feat(vpc): add support for enable-routing (#4107)

scaleway-bot · remyleone · web-flow · commit 36724d8a055f · 2024-09-09T12:47:25.000Z
Co-authored-by: Rémy Léone &lt;rleone@scaleway.com&gt;
diff --git a/cmd/scw/testdata/test-all-usage-vpc-route-enable-routing-usage.golden b/cmd/scw/testdata/test-all-usage-vpc-route-enable-routing-usage.golden
@@ -0,0 +1,19 @@
+🎲🎲🎲 EXIT CODE: 0 🎲🎲🎲
+🟥🟥🟥 STDERR️️ 🟥🟥🟥️
+Enable routing on an existing VPC. Note that you will not be able to deactivate it afterwards.
+
+USAGE:
+  scw vpc route enable-routing <vpc-id ...> [arg=value ...]
+
+ARGS:
+  vpc-id            VPC ID
+  [region=fr-par]   Region to target. If none is passed will use default region from the config (fr-par | nl-ams | pl-waw)
+
+FLAGS:
+  -h, --help   help for enable-routing
+
+GLOBAL FLAGS:
+  -c, --config string    The path to the config file
+  -D, --debug            Enable debug mode
+  -o, --output string    Output format: json or human, see 'scw help output' for more info (default "human")
+  -p, --profile string   The config profile to use
diff --git a/cmd/scw/testdata/test-all-usage-vpc-route-usage.golden b/cmd/scw/testdata/test-all-usage-vpc-route-usage.golden
@@ -3,7 +3,10 @@
 Custom routes.
 
 USAGE:
-  scw vpc route
+  scw vpc route <command>
+
+AVAILABLE COMMANDS:
+  enable-routing Enable routing on a VPC
 
 FLAGS:
   -h, --help   help for route
@@ -13,3 +16,5 @@ GLOBAL FLAGS:
   -D, --debug            Enable debug mode
   -o, --output string    Output format: json or human, see 'scw help output' for more info (default "human")
   -p, --profile string   The config profile to use
+
+Use "scw vpc route [command] --help" for more information about a command.
diff --git a/docs/commands/vpc.md b/docs/commands/vpc.md
@@ -11,6 +11,7 @@ This API allows you to manage your Virtual Private Clouds (VPCs) and Private Net
   - [Migrate Private Networks from zoned to regional](#migrate-private-networks-from-zoned-to-regional)
   - [Update Private Network](#update-private-network)
 - [Route management command](#route-management-command)
+  - [Enable routing on a VPC](#enable-routing-on-a-vpc)
 - [Routes management command](#routes-management-command)
   - [Return routes with associated next hop data](#return-routes-with-associated-next-hop-data)
 - [Subnet management command](#subnet-management-command)
@@ -189,15 +190,26 @@ scw vpc private-network update <private-network-id ...> [arg=value ...]
 
 Custom routes.
 
-Custom routes.
+
+### Enable routing on a VPC
+
+Enable routing on an existing VPC. Note that you will not be able to deactivate it afterwards.
 
 **Usage:**
 
 ```
-scw vpc route
+scw vpc route enable-routing <vpc-id ...> [arg=value ...]
 ```
 
 
+**Args:**
+
+| Name |   | Description |
+|------|---|-------------|
+| vpc-id | Required | VPC ID |
+| region | Default: `fr-par`<br />One of: `fr-par`, `nl-ams`, `pl-waw` | Region to target. If none is passed will use default region from the config |
+
+
 
 ## Routes management command
 
diff --git a/internal/namespaces/vpc/v2/vpc_cli.go b/internal/namespaces/vpc/v2/vpc_cli.go
@@ -37,6 +37,7 @@ func GetGeneratedCommands() *core.Commands {
 		vpcPrivateNetworkDelete(),
 		vpcPrivateNetworkMigrateToRegional(),
 		vpcPrivateNetworkEnableDHCP(),
+		vpcRouteEnableRouting(),
 		vpcRoutesList(),
 	)
 }
@@ -656,6 +657,36 @@ func vpcPrivateNetworkEnableDHCP() *core.Command {
 	}
 }
 
+func vpcRouteEnableRouting() *core.Command {
+	return &core.Command{
+		Short:     `Enable routing on a VPC`,
+		Long:      `Enable routing on an existing VPC. Note that you will not be able to deactivate it afterwards.`,
+		Namespace: "vpc",
+		Resource:  "route",
+		Verb:      "enable-routing",
+		// Deprecated:    false,
+		ArgsType: reflect.TypeOf(vpc.EnableRoutingRequest{}),
+		ArgSpecs: core.ArgSpecs{
+			{
+				Name:       "vpc-id",
+				Short:      `VPC ID`,
+				Required:   true,
+				Deprecated: false,
+				Positional: true,
+			},
+			core.RegionArgSpec(scw.RegionFrPar, scw.RegionNlAms, scw.RegionPlWaw),
+		},
+		Run: func(ctx context.Context, args interface{}) (i interface{}, e error) {
+			request := args.(*vpc.EnableRoutingRequest)
+
+			client := core.ExtractClient(ctx)
+			api := vpc.NewAPI(client)
+			return api.EnableRouting(request)
+
+		},
+	}
+}
+
 func vpcRoutesList() *core.Command {
 	return &core.Command{
 		Short:     `Return routes with associated next hop data`,
