Skip to content

feat(k8s): add exec-credential #4069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Aug 22, 2024
Merged

feat(k8s): add exec-credential #4069

merged 7 commits into from
Aug 22, 2024

Conversation

jtherin
Copy link
Member

@jtherin jtherin commented Aug 22, 2024

No description provided.

@jtherin jtherin requested a review from Codelax as a code owner August 22, 2024 12:05
@github-actions github-actions bot added the k8s Kubernetes Kapsule issues, bugs and feature requests label Aug 22, 2024
@jtherin jtherin changed the title feat(k8s): add exec-credentials feat(k8s): add exec-credential Aug 22, 2024
@jtherin jtherin requested a review from remyleone as a code owner August 22, 2024 13:57
@codecov-commenter
Copy link

codecov-commenter commented Aug 22, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 78.94737% with 8 lines in your changes missing coverage. Please review.

Project coverage is 69.40%. Comparing base (5bf53e0) to head (e541b03).
Report is 210 commits behind head on master.

Files Patch % Lines
...ternal/namespaces/k8s/v1/custom_execcredentials.go 78.37% 6 Missing and 2 partials ⚠️

❗ There is a different number of reports uploaded between BASE (5bf53e0) and HEAD (e541b03). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (5bf53e0) HEAD (e541b03)
2 1
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #4069      +/-   ##
==========================================
- Coverage   75.45%   69.40%   -6.06%     
==========================================
  Files         202      292      +90     
  Lines       44323    55663   +11340     
==========================================
+ Hits        33444    38633    +5189     
- Misses       9653    15450    +5797     
- Partials     1226     1580     +354

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@remyleone remyleone added this pull request to the merge queue Aug 22, 2024
Merged via the queue into scaleway:master with commit 4e4d95b Aug 22, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@remyleone remyleone remyleone approved these changes

@Codelax Codelax Awaiting requested review from Codelax

Assignees
No one assigned
Labels
k8s Kubernetes Kapsule issues, bugs and feature requests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jtherin @codecov-commenter @remyleone