Skip to content

fix(arg-spec): revert multi positional arg definition #4627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 1, 2025
Merged

Conversation

kindermoumoute
Copy link
Contributor

Setting multiple arg specs with positional=true would select the last arg spec with this attribute. Which is a bit too magical

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Release note for CHANGELOG:


Setting multiple arg specs with positional=true would select the last
arg spec with this attribute. Which is a bit too magical

Signed-off-by: Olivier Cano <ocano@scaleway.com>
@Laure-di Laure-di added this pull request to the merge queue Apr 1, 2025
Merged via the queue into master with commit c798958 Apr 1, 2025
16 checks passed
@Laure-di Laure-di deleted the tiny-revert branch April 1, 2025 13:04
Laure-di pushed a commit to remyleone/scaleway-cli that referenced this pull request Apr 4, 2025
Signed-off-by: Olivier Cano <ocano@scaleway.com>
Laure-di pushed a commit to Laure-di/scaleway-cli that referenced this pull request Apr 7, 2025
Signed-off-by: Olivier Cano <ocano@scaleway.com>
Laure-di pushed a commit to Laure-di/scaleway-cli that referenced this pull request Apr 9, 2025
Signed-off-by: Olivier Cano <ocano@scaleway.com>
Laure-di pushed a commit to Laure-di/scaleway-cli that referenced this pull request Apr 9, 2025
Signed-off-by: Olivier Cano <ocano@scaleway.com>
Laure-di pushed a commit to Laure-di/scaleway-cli that referenced this pull request Apr 10, 2025
Signed-off-by: Olivier Cano <ocano@scaleway.com>
Laure-di pushed a commit to Laure-di/scaleway-cli that referenced this pull request Apr 10, 2025
Signed-off-by: Olivier Cano <ocano@scaleway.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants