Skip to content

add s3test for sql #5718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jul 4, 2024
Merged

add s3test for sql #5718

merged 8 commits into from
Jul 4, 2024

Conversation

kmlebedev
Copy link
Contributor

What problem are we solving?

split #5580

How are we solving the problem?

How is the PR tested?

Checks

  • I have added unit tests if possible.
  • I will add related wiki document changes and link to this PR after merging.

@chrislusf
Copy link
Collaborator

Thanks for the hard work!

tip: Smaller PRs will get merged faster.

@kmlebedev
Copy link
Contributor Author

@chrislusf Hello, everything seems to be ready here?

@kmlebedev kmlebedev mentioned this pull request Jul 2, 2024
Closed
2 tasks
@kmlebedev
Copy link
Contributor Author

@chrislusf Hello, I removed xmlns

@chrislusf chrislusf merged commit f77eee6 into seaweedfs:master Jul 4, 2024
6 checks passed
@hutao-bot hutao-bot bot mentioned this pull request Feb 9, 2025
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrislusf chrislusf chrislusf left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kmlebedev @chrislusf