volume server: added write blob grpc api similar to http #6156
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ollelogdahl
force-pushed
the
grpc-volume-api
branch
from
99c5fb9 to
516405a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem are we solving?
Currently, only the http API on the volume server can create new blobs and automatically handle replication. This patch
adds a gRPC API that can be used by other systems to write new blobs. Compared to the other gRPC procedures which are more internal, this API is intended specifically for external systems. See issue #6146
How are we solving the problem?
http.Request, so that has been broken out.WriteBlobwhich performs the same logic as weed/server/volume_server_handlers_write.go:18.How is the PR tested?
Currently only by writing a separate client and connect to it.
Todo
Checks