enh: simulate random i/o error #27155
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gccgdb1234
reviewed
Aug 12, 2024
| @@ -64,6 +64,20 @@ typedef struct TdFile { | |||
|
|
|||
| #define FILE_WITH_LOCK 1 | |||
|
|
|||
| #ifdef BUILD_WITH_RAND_ERR | |||
There was a problem hiding this comment.
类似这样的宏潘魏应该已经加过了，不需要重复加，只要在特定地方用它就行了。如果觉得他的宏名字起得不够通用，可以把名字改得通用一些。
There was a problem hiding this comment.
潘魏暂未定义类似的宏；资源类的随机失败常见的也就是内存和文件；如果要增加公共宏，可以放在 tutil.h 或是 tdef.h，而 tutil.h 引用了其他头文件，因此在使用 tutil.h 时会引入一些新的头文件，tdef.h 基本是一些常量类型的定义，所以两个位置都感觉不是很好。基于以上几点，暂未增加公用的宏，如果以后还要继续增加其他类型的资源随机失败，再考虑将 osFile.c/osMemory.c 的定义提取出来。
hzcheng
approved these changes
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.