Feat/updateMultiTag #28925
Merged
Feat/updateMultiTag #28925
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hzcheng
approved these changes
Nov 28, 2024
kailixu
reviewed
Nov 28, 2024
| goto end; | ||
| } | ||
| cJSON* colValue = cJSON_CreateString(buf); | ||
| RAW_NULL_CHECK(colValue); |
There was a problem hiding this comment.
- 此处返回，buf 会泄露。 2. 另外，buf 在多个 tag 之间是否可以共用。
- 原来修改单个 tagVal 的逻辑： TSDB_ALTER_TABLE_UPDATE_TAG_VAL，有类似的泄漏风险问题。
There was a problem hiding this comment.
- 此处返回，buf 会泄露。 2. 另外，buf 在多个 tag 之间是否可以共用。
- 原来修改单个 tagVal 的逻辑： TSDB_ALTER_TABLE_UPDATE_TAG_VAL，有类似的泄漏风险问题。
- 确实有个这个问题，要改的话，整个函数都需要改，暂时先不改
- buf 共用的问题，这个之后可以优化下。
kailixu
reviewed
Nov 28, 2024
| } | ||
| cJSON* colValue = cJSON_CreateString(buf); | ||
| RAW_NULL_CHECK(colValue); | ||
| RAW_FALSE_CHECK(cJSON_AddItemToObject(member, "colValue", colValue)); |
There was a problem hiding this comment.
同上
整个函数都没有处理这个异常跳出，导致内存泄露的问题，先不改了，主要是现在时间比较紧，我再其他PR中处理这个
kailixu
reviewed
Nov 28, 2024
| } | ||
|
|
||
| if (NULL == ctbEntry.ctbEntry.pTags) { | ||
| metaError("meta/table: null tags, update tag val failed."); |
There was a problem hiding this comment.
- metaWLock 需要释放
- 另外，如果 ctbEntry.ctbEntry.pTags 为NULL，是不是就跳转至 _err了，这个分支根本就不存在。
There was a problem hiding this comment.
- metaWLock 需要释放
- 另外，如果 ctbEntry.ctbEntry.pTags 为NULL，是不是就跳转至 _err了，这个分支根本就不存在。
这是个无效的逻辑
kailixu
reviewed
Nov 28, 2024
kailixu
approved these changes
Nov 28, 2024
| sql insert into $tb values(now, 1) | ||
| sql_error alter table $mt set tag tgcol1 = 1,tagcol2 = 2, tag3 = 4 # set tag value on supertable | ||
| sql_error alter table $ntable set tag f = 10 # set normal table value | ||
| sql_error alter table $tbj set tag tagCol1=1,tagCol1 = 2 # dumplicate tag name |
There was a problem hiding this comment.
dumplicate: typo -> duplicate
| sql_error alter table $mt set tag tgcol1 = 1,tagcol2 = 2, tag3 = 4 # set tag value on supertable | ||
| sql_error alter table $ntable set tag f = 10 # set normal table value | ||
| sql_error alter table $tbj set tag tagCol1=1,tagCol1 = 2 # dumplicate tag name | ||
| sql_error alter table $tbj set tag tagCol1=1,tagCol1 = 2 # not exist tag |
There was a problem hiding this comment.
这两个列都是存在的，只是 duplicate。是否按注释说的，要增加一个列不存在，以及 列 为 NULL 值的 用例。
There was a problem hiding this comment.
这两个列都是存在的，只是 duplicate。是否按注释说的，要增加一个列不存在，以及 列 为 NULL 值的 用例。
这个在整个脚本的最后有，有动态删除tag之后，然后设值的，不过这里可以修改下，放在一块
| } | ||
| if (c != 0) { | ||
| tdbTbcClose(pUidIdxc); | ||
| metaError("meta/table: invalide c: %" PRId32 " update tb tag val failed.", c); |
| if (c != 0) { | ||
| tdbTbcClose(pUidIdxc); | ||
| tdbTbcClose(pTbDbc); | ||
| metaError("meta/table: invalide c: %" PRId32 " update tb tag val failed.", c); |
|
guanshengliang
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist