fix(stream): check the checkpoint-report transId and checkpointId #29615
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d identify the expired checkpoint-report info.
hjxilinx
requested review from
guanshengliang,
hzcheng and
dapan1121
as code owners
…Id, and update the consensus-checkpoint id in mnode.
54liuyao
approved these changes
Jan 23, 2025
dapan1121
reviewed
Jan 23, 2025
| if (existed != numOfTasks) { | ||
| mDebug("stream:0x%" PRIx64 " %s %d/%d tasks send checkpoint-report, %d not send", pReportInfo->streamId, pName, | ||
| existed, numOfTasks, numOfTasks - existed); | ||
| return -1; |
There was a problem hiding this comment.
这个是表示true/false，不是一个真正的错误，本来是想用 bool 的。
guanshengliang
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix(stream): check the checkpoint-report transId and checkpointId, and identify the expired checkpoint-report info.
Checklist
Please check the items in the checklist if applicable.