Optimise StackTraceSnippet.Get (MiniProfiler#605)

benbryant0 · web-flow · commit ce90f4033770 · 2022-05-28T17:06:44.000-04:00
* Remove RuntimeIdentifier

This creates a self-contained executable, which BDN doesn't seem to support

* Remove commented test code

* Set up profiler per iteration

If the benchmark is fast enough BDN will run enough operations per iteration that the accumulated CustomTimings will eat all memory.

* Bench with stack trace vs without

* Cache assembly &amp; module names

These are not (currently) cached in any meaningful way. Type &amp; MethodInfo don't have the same problem.
diff --git a/benchmarks/MiniProfiler.Benchmarks/Benchmarks/CustomTimingBenchmarks.cs b/benchmarks/MiniProfiler.Benchmarks/Benchmarks/CustomTimingBenchmarks.cs
@@ -4,32 +4,35 @@
 
 namespace Benchmarks
 {
-    [SimpleJob(RuntimeMoniker.Net472)]
-    [SimpleJob(RuntimeMoniker.Net50)]
+    [SimpleJob(RuntimeMoniker.Net472, invocationCount: 50_000)]
+    [SimpleJob(RuntimeMoniker.Net50, invocationCount: 50_000)]
     [Config(typeof(Configs.Memory))]
     public class CustomTimingBenchmarks
     {
         private MiniProfiler Profiler;
 
-        [GlobalSetup]
+        [Params(true, false)]
+        public bool IncludeStackTrace { get; set; }
+
+        [IterationSetup]
         public void SetupData()
         {
             Profiler = new MiniProfiler("Test", new MiniProfilerBenchmarkOptions());
         }
 
         [Benchmark(Description = "Creation of a standalone CustomTiming")]
-        public CustomTiming Creation() => new CustomTiming(Profiler, "Test");
+        public CustomTiming Creation() => new CustomTiming(Profiler, "Test", includeStackTrace: IncludeStackTrace);
 
         [Benchmark(Description = "Creation a CustomTiming via MiniProfiler")]
         public void AddingToMiniProfiler()
         {
-            Profiler.CustomTiming("Test", "MyCategory");
+            Profiler.CustomTiming("Test", "MyCategory", includeStackTrace: IncludeStackTrace);
         }
 
         [Benchmark(Description = "Using a CustomTiming with MiniProfiler")]
         public void UsingWithMiniProfiler()
         {
-            using (Profiler.CustomTiming("Test", "MyCategory"))
+            using (Profiler.CustomTiming("Test", "MyCategory", includeStackTrace: IncludeStackTrace))
             {
                 // Trigger the .Dispose()
             }
diff --git a/benchmarks/MiniProfiler.Benchmarks/MiniProfiler.Benchmarks.csproj b/benchmarks/MiniProfiler.Benchmarks/MiniProfiler.Benchmarks.csproj
@@ -6,7 +6,6 @@
     <RootNamespace>Benchmarks</RootNamespace>
     <Configuration>Release</Configuration>
     <TargetFrameworks>net472;net5.0</TargetFrameworks>
-    <RuntimeIdentifier>win7-x64</RuntimeIdentifier>
     <PlatformTarget>AnyCPU</PlatformTarget>
     <SignAssembly>false</SignAssembly>
     <LangVersion>9</LangVersion>
diff --git a/benchmarks/MiniProfiler.Benchmarks/Program.cs b/benchmarks/MiniProfiler.Benchmarks/Program.cs
@@ -7,11 +7,6 @@ public static class Program
     {
         public static void Main(string[] args)
         {
-            //var creation = new Benchmarks.CreationBenchmarks();
-            //while (true)
-            //{
-            //    creation.StartStopProfiler();
-            //}
             BenchmarkSwitcher.FromAssembly(typeof(Program).GetTypeInfo().Assembly).Run(args);
         }
     }
diff --git a/src/MiniProfiler.Shared/Helpers/StackTraceSnippet.cs b/src/MiniProfiler.Shared/Helpers/StackTraceSnippet.cs
@@ -1,5 +1,6 @@
 ﻿using StackExchange.Profiling.Internal;
 using System;
+using System.Collections.Concurrent;
 using System.Collections.Generic;
 using System.Diagnostics;
 using System.Net;
@@ -14,6 +15,9 @@ namespace StackExchange.Profiling.Helpers
     /// </summary>
     public static class StackTraceSnippet
     {
+        private static readonly ConcurrentDictionary<Assembly, string> AssemblyNames = new();
+        private static readonly ConcurrentDictionary<Module, string> ModuleNames = new();
+
         /// <summary>
         /// Gets the current formatted and filtered stack trace.
         /// </summary>
@@ -56,14 +60,14 @@ bool ShouldExcludeType(MethodBase method)
                 if (stackLength >= options.StackMaxLength
                     // ASP.NET: no need to continue up the chain
                     || method.Name == "System.Web.HttpApplication.IExecutionStep.Execute"
-                    || (method.Module.Name == "Microsoft.AspNetCore.Mvc.Core.dll" && method.DeclaringType.Name == "ObjectMethodExecutor"))
+                    || (ModuleNames.GetOrAdd(method.Module, m => m.Name) == "Microsoft.AspNetCore.Mvc.Core.dll" && method.DeclaringType.Name == "ObjectMethodExecutor"))
                 {
                     frames[i] = null;
                     startFrame = i < 0 ? 0 : i - 1;
                     break;
                 }
                 else if (ShouldExcludeType(method)
-                    || options.ExcludedAssemblies.Contains(method.Module.Assembly.GetName().Name)
+                    || options.ExcludedAssemblies.Contains(AssemblyNames.GetOrAdd(method.Module.Assembly, a => a.GetName().Name))
                     || options.ExcludedMethods.Contains(method.Name))
                 {
                     frames[i] = null;

Original file line number	Diff line number	Diff line change
`@@ -4,32 +4,35 @@`
`4`	`4`
`5`	`5`	`namespace Benchmarks`
`6`	`6`	`{`
`7`		`- [SimpleJob(RuntimeMoniker.Net472)]`
`8`		`- [SimpleJob(RuntimeMoniker.Net50)]`
	`7`	`+ [SimpleJob(RuntimeMoniker.Net472, invocationCount: 50_000)]`
	`8`	`+ [SimpleJob(RuntimeMoniker.Net50, invocationCount: 50_000)]`
`9`	`9`	`[Config(typeof(Configs.Memory))]`
`10`	`10`	`public class CustomTimingBenchmarks`
`11`	`11`	`{`
`12`	`12`	`private MiniProfiler Profiler;`
`13`	`13`
`14`		`- [GlobalSetup]`
	`14`	`+ [Params(true, false)]`
	`15`	`+ public bool IncludeStackTrace { get; set; }`
	`16`	`+`
	`17`	`+ [IterationSetup]`
`15`	`18`	`public void SetupData()`
`16`	`19`	`{`
`17`	`20`	`Profiler = new MiniProfiler("Test", new MiniProfilerBenchmarkOptions());`
`18`	`21`	`}`
`19`	`22`
`20`	`23`	`[Benchmark(Description = "Creation of a standalone CustomTiming")]`
`21`		`- public CustomTiming Creation() => new CustomTiming(Profiler, "Test");`
	`24`	`+ public CustomTiming Creation() => new CustomTiming(Profiler, "Test", includeStackTrace: IncludeStackTrace);`
`22`	`25`
`23`	`26`	`[Benchmark(Description = "Creation a CustomTiming via MiniProfiler")]`
`24`	`27`	`public void AddingToMiniProfiler()`
`25`	`28`	`{`
`26`		`- Profiler.CustomTiming("Test", "MyCategory");`
	`29`	`+ Profiler.CustomTiming("Test", "MyCategory", includeStackTrace: IncludeStackTrace);`
`27`	`30`	`}`
`28`	`31`
`29`	`32`	`[Benchmark(Description = "Using a CustomTiming with MiniProfiler")]`
`30`	`33`	`public void UsingWithMiniProfiler()`
`31`	`34`	`{`
`32`		`- using (Profiler.CustomTiming("Test", "MyCategory"))`
	`35`	`+ using (Profiler.CustomTiming("Test", "MyCategory", includeStackTrace: IncludeStackTrace))`
`33`	`36`	`{`
`34`	`37`	`// Trigger the .Dispose()`
`35`	`38`	`}`
Original file line number	Diff line number	Diff line change
`@@ -7,11 +7,6 @@ public static class Program`
`7`	`7`	`{`
`8`	`8`	`public static void Main(string[] args)`
`9`	`9`	`{`
`10`		`- //var creation = new Benchmarks.CreationBenchmarks();`
`11`		`- //while (true)`
`12`		`- //{`
`13`		`- // creation.StartStopProfiler();`
`14`		`- //}`
`15`	`10`	`BenchmarkSwitcher.FromAssembly(typeof(Program).GetTypeInfo().Assembly).Run(args);`
`16`	`11`	`}`
`17`	`12`	`}`