fixed the broken 'first render' logic. fixes marionettejs#295

Derick Bailey · Derick Bailey · commit 050bc1da0a7b · 2012-10-18T08:36:41.000-05:00
diff --git a/src/marionette.layout.js b/src/marionette.layout.js
@@ -13,6 +13,7 @@ Marionette.Layout = Marionette.ItemView.extend({
   // Ensure the regions are avialable when the `initialize` method
   // is called.
   constructor: function () {
+    this._firstRender = true;
     this.initializeRegions();
     Backbone.Marionette.ItemView.apply(this, arguments);
   },
@@ -22,13 +23,16 @@ Marionette.Layout = Marionette.ItemView.extend({
   // views that the regions are showing and then reset the `el`
   // for the regions to the newly rendered DOM elements.
   render: function(){
-    // If this is not the first render call, then we need to 
-    // re-initializing the `el` for each region
-    if (!this._firstRender){
+
+    if (this._firstRender){
+      // if this is the first render, don't do anything to
+      // reset the regions
+      this._firstRender = false;
+    } else {
+      // If this is not the first render call, then we need to 
+      // re-initializing the `el` for each region
       this.closeRegions();
       this.reInitializeRegions();
-    } else {
-      this._firstRender = false;
     }
 
     var result = Marionette.ItemView.prototype.render.apply(this, arguments);
